Skip to content

RFC powerpc: change syscall error return scheme

Nicholas Piggin linuxppc-dev lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest2 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2powerpc/signal: Clean up pt_regs accessarch/powerpc/kernel/signal.c arch/powerpc/kernel/signal_64.c+9 -70 replies
2/2powerpc/syscall: rework syscall return value handlingarch/powerpc/include/asm/ptrace.h arch/powerpc/include/asm/syscall.h arch/powerpc/kernel/interrupt.c +2 more+60 -720 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC PATCH 0/2] powerpc: change syscall error return scheme

Hi,

I've been toying with the seccomp vs syscall return value problems, and wonder if something like this approach could give us a simpler alternative. Basically all the core code uses -errno return value, then we convert it to the powerpc convention at the last minute when returning.

This seems to pass the seccomp_bpf test cases when applied with the set syscall info ptrace patches

https://lore.kernel.org/lkml/[email protected]/

With patch 1 of that series reverted.

One concern is working out exact details of what tracers can see and trying to ensure it doesn't break some corner case.

This could possibly be done for the other weird archs too, if it works out for powerpc

Thanks,
Nick

Nicholas Piggin (2):
powerpc/signal: Clean up pt_regs access powerpc/syscall: rework syscall return value handling

 arch/powerpc/include/asm/ptrace.h             | 13 +---
 arch/powerpc/include/asm/syscall.h            | 31 +--------
 arch/powerpc/kernel/interrupt.c               | 16 +++--
 arch/powerpc/kernel/signal.c                  | 67 ++++++++++---------
 arch/powerpc/kernel/signal_64.c               |  5 +-
 tools/testing/selftests/seccomp/seccomp_bpf.c | 16 +++++
 6 files changed, 69 insertions(+), 79 deletions(-)
Signature · 1 line
2.47.1