Skip to content

PCI: endpoint: Allow EPF drivers to configure the size of Resizable BARs

Niklas Cassel linux-arm-kernel linux-pci linux-rockchip 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v4 Latest7 patches 10 repliesIn review

Changes in v4 from the cover letter

-Picked up tags.
-Addressed comments from Mani.

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7PCI: endpoint: Allow EPF drivers to configure the size of Resizable BARsdrivers/pci/endpoint/pci-epc-core.c drivers/pci/endpoint/pci-epf-core.c include/linux/pci-epc.h+12 -01 reply
2/7PCI: endpoint: Add pci_epc_bar_size_to_rebar_cap()drivers/pci/endpoint/pci-epc-core.c include/linux/pci-epc.h+28 -05 replies
3/7PCI: dwc: ep: Move dw_pcie_ep_find_ext_capability()drivers/pci/controller/dwc/pcie-designware-ep.c+18 -180 replies
4/7PCI: dwc: endpoint: Allow EPF drivers to configure the size of Resizable BARsdrivers/pci/controller/dwc/pcie-designware-ep.c+167 -151 reply
5/7PCI: keystone: Describe Resizable BARs as Resizable BARsdrivers/pci/controller/dwc/pci-keystone.c+2 -20 replies
6/7PCI: keystone: Specify correct alignment requirementdrivers/pci/controller/dwc/pci-keystone.c+1 -11 reply
7/7PCI: dw-rockchip: Describe Resizable BARs as Resizable BARsdrivers/pci/controller/dwc/pcie-dw-rockchip.c+11 -110 replies

Reviews trailers per patch

All 7 patches have a Reviewed-by or Acked-by.

PatchManivannan Sadhasivam
1/7R-b
2/7R-b
3/7R-b
4/7R-b
5/7R-b
6/7R-b
7/7R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/7] PCI: endpoint: Allow EPF drivers to configure the size of Resizable BARs

The PCI endpoint framework currently does not support resizable BARs.

Add a new BAR type BAR_RESIZABLE, so that EPC drivers can support resizable BARs properly.

For a resizable BAR, we will only allow a single supported size. This is by design, as we do not need/want the complexity of the host side resizing our resizable BAR.

In the DWC driver specifically, the DWC driver currently handles resizable BARs using an ugly hack where a resizable BAR is force set to a fixed size BAR with 1 MB size if detected. This is bogus, as a resizable BAR can be configured to sizes other than 1 MB.

With these changes, an EPF driver will be able to call pci_epc_set_bar() to configure a resizable BAR to an arbitrary size, just like for BAR_PROGRAMMABLE. Thus, DWC based EPF drivers will no longer be forced to a bogus 1 MB forced size for resizable BARs.

Tested/verified on a Radxa Rock 5b (rk3588) by:
-Modifying pci-epf-test.c to request BAR sizes that are larger than 1 MB:
-static size_t bar_size[] = { 512, 512, 1024, 16384, 131072, 1048576 }; +static size_t bar_size[] = { SZ_1M, SZ_1M, SZ_2M, SZ_2M, SZ_4M, SZ_4M }; (Make sure to set CONFIG_CMA_ALIGNMENT=10 such that dma_alloc_coherent()
calls are aligned even for allocations larger than 1 MB.)
-Rebooting the host to make sure that the DWC EP driver configures the BARs
correctly after receiving a link down event.
-Modifying EPC features to configure a BAR as 64-bit, to make sure that we
handle 64-bit BARs correctly.
-Modifying the DWC EP driver to set a size larger than 2 GB, to make sure
we handle BAR sizes larger than 2 GB (for 64-bit BARs) correctly.
-Running the consecutive BAR test in pci_endpoint_test.c to make sure that
the address translation works correctly.

Changes since V3:
-Picked up tags.
-Addressed comments from Mani.

Kind regards,
Niklas

Niklas Cassel (7):
PCI: endpoint: Allow EPF drivers to configure the size of Resizable
BARs
PCI: endpoint: Add pci_epc_bar_size_to_rebar_cap()
PCI: dwc: ep: Move dw_pcie_ep_find_ext_capability()
PCI: dwc: endpoint: Allow EPF drivers to configure the size of
Resizable BARs
PCI: keystone: Describe Resizable BARs as Resizable BARs
PCI: keystone: Specify correct alignment requirement
PCI: dw-rockchip: Describe Resizable BARs as Resizable BARs

 drivers/pci/controller/dwc/pci-keystone.c     |   6 +-
 .../pci/controller/dwc/pcie-designware-ep.c   | 218 +++++++++++++++---
 drivers/pci/controller/dwc/pcie-dw-rockchip.c |  22 +-
 drivers/pci/endpoint/pci-epc-core.c           |  31 +++
 drivers/pci/endpoint/pci-epf-core.c           |   4 +
 include/linux/pci-epc.h                       |   5 +
 6 files changed, 239 insertions(+), 47 deletions(-)
Signature · 1 line
2.48.1