Skip to content

A few more CRC32 library cleanups

Eric Biggers linux-crypto lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest6 patches 1 replyIn review
  2. v15 patches 3 repliesSuperseded

Changes in v2 from the cover letter

- Added mips/crc32 patch to fix a build error.
- Reformatted the kerneldoc comment for crc32c_combine() and moved it to the correct place.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6mips/crc32: remove unused enumsarch/mips/lib/crc32-mips.c+0 -91 reply
2/6lib/crc32: use void pointer for datainclude/linux/crc32.h+3 -30 replies
3/6lib/crc32: don't bother with pure and const function attributesarch/arm64/lib/crc32-glue.c arch/riscv/lib/crc32-riscv.c include/linux/crc32.h +1 more+27 -290 replies
4/6lib/crc32: standardize on crc32c() name for Castagnoli CRC32crypto/crc32c_generic.c drivers/crypto/stm32/stm32-crc32.c drivers/md/raid5-cache.c +8 more+32 -450 replies
5/6lib/crc32: rename __crc32c_le_combine() to crc32c_combine()drivers/infiniband/sw/siw/siw.h include/linux/crc32.h include/net/sctp/checksum.h +2 more+21 -230 replies
6/6lib/crc32: remove "_le" from crc32c base and arch functionsarch/arm/lib/crc32-glue.c arch/arm64/lib/crc32-glue.c arch/loongarch/lib/crc32-loongarch.c +9 more+40 -400 replies

Reviews trailers per patch

All 6 patches have a Reviewed-by or Acked-by.

PatchArd Biesheuvel
1/6A-b
2/6R-b
3/6R-b
4/6R-b
5/6R-b
6/6R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/6] A few more CRC32 library cleanups

This series makes the CRC32 library functions have consistent prototypes, and it makes the Castagnoli CRC32 be consistently called simply crc32c instead of a mix of crc32c, crc32c_le, and __crc32c_le.

This series applies to the crc tree.

Changed in v2:
- Added mips/crc32 patch to fix a build error.
- Reformatted the kerneldoc comment for crc32c_combine() and moved it to the correct place.

Eric Biggers (6):
mips/crc32: remove unused enums
lib/crc32: use void pointer for data
lib/crc32: don't bother with pure and const function attributes lib/crc32: standardize on crc32c() name for Castagnoli CRC32 lib/crc32: rename __crc32c_le_combine() to crc32c_combine() lib/crc32: remove "_le" from crc32c base and arch functions

 arch/arm/lib/crc32-glue.c                     | 12 ++--
 arch/arm64/lib/crc32-glue.c                   | 10 ++--
 arch/loongarch/lib/crc32-loongarch.c          |  6 +-
 arch/mips/lib/crc32-mips.c                    | 15 +----
 arch/powerpc/lib/crc32-glue.c                 | 10 ++--
 arch/riscv/lib/crc32-riscv.c                  | 17 +++---
 arch/s390/lib/crc32-glue.c                    |  2 +-
 arch/sparc/lib/crc32_glue.c                   | 10 ++--
 arch/x86/lib/crc32-glue.c                     |  6 +-
 crypto/crc32c_generic.c                       |  8 +--
 drivers/crypto/stm32/stm32-crc32.c            |  2 +-
 drivers/infiniband/sw/siw/siw.h               |  4 +-
 drivers/md/raid5-cache.c                      | 31 +++++------
 drivers/md/raid5-ppl.c                        | 16 +++---
 .../net/ethernet/broadcom/bnx2x/bnx2x_sp.c    |  2 +-
 drivers/thunderbolt/ctl.c                     |  2 +-
 drivers/thunderbolt/eeprom.c                  |  2 +-
 include/linux/crc32.h                         | 55 +++++++++----------
 include/linux/crc32c.h                        |  8 ---
 include/net/sctp/checksum.h                   |  7 +--
 lib/crc32.c                                   | 21 ++++---
 lib/crc_kunit.c                               |  2 +-
 sound/soc/codecs/aw88395/aw88395_device.c     |  2 +-
 23 files changed, 112 insertions(+), 138 deletions(-)

base-commit: 0ebb2a6a60d195071d19c34da97b4ce67f4d7086

Signature · 1 line
2.48.1