Skip to content

btf_encoder: emit type tags for bpf_arena pointers

Ihor Solodrai bpf dwarves 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest6 patches 12 repliesIn review
  2. v34 patches 5 repliesSuperseded
  3. v24 patches 6 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v13 patches7 repliesSuperseded

Changes in v4 from the cover letter

* Add a patch (#2) replacing compile-time libbpf version checks with runtime checks for symbol availablility
* Add a patch (#3) bumping libbpf submodule commit to latest master
* Modify "btf_encoder: emit type tags for bpf_arena pointers"

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6btf_encoder: refactor btf_encoder__tag_kfuncs()btf_encoder.c+54 -1350 replies
2/6btf_encoder: use __weak declarations of version-dependent libbpf APIbtf_encoder.c dwarves.h pahole.c+29 -322 replies
3/6pahole: sync with libbpf mainlinelib/bpf+1 -10 replies
4/6btf_encoder: emit type tags for bpf_arena pointersbtf_encoder.c dwarves.h+87 -10 replies
5/6pahole: introduce --btf_feature=attributesbtf_encoder.c dwarves.h pahole.c+14 -20 replies
6/6man-pages: describe attributes and remove reproducible_buildman-pages/pahole.1+4 -30 replies

Reviews trailers per patch

4 of 6 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchJiri OlsaEduard ZingermanAlan MaguireIhor Solodrai
SeriesA-b
1/6R-b A-b
2/6
3/6
4/6R-b R-b
5/6R-b A-b R-b
6/6R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v4 thread

Cover letter [PATCH dwarves v4 0/6] btf_encoder: emit type tags for bpf_arena pointers

This patch series implements emitting appropriate BTF type tags for argument and return types of kfuncs marked with KF_ARENA_* flags.

For additional context see the description of BPF patch "bpf: define KF_ARENA_* flags for bpf_arena kfuncs" [1].

The feature depends on recent changes in libbpf [2].

[1] https://lore.kernel.org/bpf/[email protected]/
[2] https://lore.kernel.org/bpf/[email protected]/

v3->v4:
* Add a patch (#2) replacing compile-time libbpf version checks with runtime checks for symbol availablility
* Add a patch (#3) bumping libbpf submodule commit to latest master
* Modify "btf_encoder: emit type tags for bpf_arena pointers"

    (#2->#4) to not use compile time libbpf version checks

v2->v3:
* Nits in patch #1

v1->v2:
* Rewrite patch #1 refactoring btf_encoder__tag_kfuncs(): now the post-processing step is removed entirely, and kfuncs are tagged in btf_encoder__add_func().
* Nits and renames in patch #2
* Add patch #4 editing man pages

v2: https://lore.kernel.org/dwarves/[email protected]/
v1: https://lore.kernel.org/dwarves/[email protected]/

Ihor Solodrai (6):
btf_encoder: refactor btf_encoder__tag_kfuncs()
btf_encoder: use __weak declarations of version-dependent libbpf API
pahole: sync with libbpf mainline
btf_encoder: emit type tags for bpf_arena pointers
pahole: introduce --btf_feature=attributes
man-pages: describe attributes and remove reproducible_build

 btf_encoder.c      | 328 ++++++++++++++++++++++-----------------------
 dwarves.h          |  13 +-
 lib/bpf            |   2 +-
 man-pages/pahole.1 |   7 +-
 pahole.c           |  11 +-
 5 files changed, 188 insertions(+), 173 deletions(-)
Signature · 1 line
2.48.1