Using the right format specifiers for bpftool
Status from this message: This patch was applied to bpf/bpf-next.git (master)
Get series with b4
b4 am [email protected]Versions newest first
Patches in v1 All 1 applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/1 | bpftool: Using the right format specifierstools/ tools/ tools/ +1 more | +22 | 1 reply | Applied |
Reviews trailers per patch
The patch has a Reviewed-by or Acked-by.
| Patch | Quentin Monnet |
|---|---|
| 1/1 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH bpf-next v1 0/1] Using the right format specifiers for bpftool
Fixed some incorrect formatting specifiers that were exposed when I added the "-Wformat" flag to the compiler options.
This patch doesn't include "-Wformat" in the Makefile for now, as I've only addressed some obvious semantic issues with the compiler warnings. There are still other warnings that need to be tackled.
For example, there's an ifindex that's sometimes defined as a signed type and sometimes as an unsigned type, which makes formatting a real pain
- sometimes it needs %d and sometimes %u. This might require a more fundamental fix from the variable definition side.
If the maintainer is okay with adding "-Wformat" to the tools/bpf/bpftool/Makefile, please let us know, and we can follow up with further fixes.
Jiayuan Chen (1):
bpftool: Using the right format specifiers
tools/bpf/bpftool/gen.c | 12 ++++++------ tools/bpf/bpftool/link.c | 14 +++++++------- tools/bpf/bpftool/main.c | 8 ++++---- tools/bpf/bpftool/map.c | 10 +++++----- 4 files changed, 22 insertions(+), 22 deletions(-)
Signature · 1 line
2.43.5