drm: sun4i: add Display Engine 3.3 (DE33) support
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v9 Latest24 patches 12 repliesIn review
- v22 patches 3 repliesApplied
- v12 patches 2 repliesSuperseded
Changes in v9 from the cover letter
- Combined the DE33 [1] series and the LCD [2] series to better track all patches necessary to output to an LCD display for the Allwinner H700.
- Added a required LVDS reset as requested here [3].
- Added compatible strings with a fallback for allwinner,sun50i-h616-display-engine, allwinner,sun50i-h616-tcon-top, and allwinner,sun50i-h616-sram-c.
- Added binding documentation for the LCD controller.
- Renamed the de3_sram device tree node to de33_sram.
- Corrected the LVDS reset for the LCD controller binding.
- Removed the PWM pins from the pincontroller bindings, as PWM is not yet supported.
- Reordered the patches so that a binding or a device tree node is not referenced before it is defined.
[1] https://lore.kernel.org/linux-sunxi/[email protected]/
[2] https://lore.kernel.org/linux-sunxi/[email protected]/
[3] https://lore.kernel.org/linux-sunxi/38669808.XM6RcZxFsP@jernej-laptop/
Patches in v9 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/24 | dt-bindings: clock: sun50i-h616-ccu: Add LVDS resetinclude/ | +1 | 1 reply | |
| 2/24 | clk: sunxi-ng: h616: Add LVDS reset for LCD TCONdrivers/ | +1 | 4 replies | |
| 3/24 | drm: sun4i: de2/de3: add mixer version enumdrivers/ drivers/ drivers/ +3 more | +23 | 0 replies | |
| 4/24 | drm: sun4i: de2/de3: refactor mixer initialisationdrivers/ | +34 | 0 replies | |
| 5/24 | drm: sun4i: de2/de3: add generic blender register reference functiondrivers/ | +6 | 0 replies | |
| 6/24 | drm: sun4i: de2/de3: use generic register reference function for layer configurationdrivers/ drivers/ drivers/ | +12 | 0 replies | |
| 7/24 | dt-bindings: allwinner: add H616 DE33 bus bindingDocumentation/ | +3 | 0 replies | |
| 8/24 | dt-bindings: allwinner: add H616 DE33 clock bindingDocumentation/ | +1 | 0 replies | |
| 9/24 | dt-bindings: allwinner: add H616 DE33 mixer bindingDocumentation/ | +32 | 0 replies | |
| 10/24 | clk: sunxi-ng: ccu: add Display Engine 3.3 (DE33) supportdrivers/ | +25 | 0 replies | |
| 11/24 | drm: sun4i: de33: vi_scaler: add Display Engine 3.3 (DE33) supportdrivers/ drivers/ | +19 | 0 replies | |
| 12/24 | drm: sun4i: de33: mixer: add Display Engine 3.3 (DE33) supportdrivers/ drivers/ | +90 | 0 replies | |
| 13/24 | drm: sun4i: de33: mixer: add mixer configuration for the H616drivers/ | +15 | 0 replies | |
| 14/24 | dt-bindings: allwinner: Add TCON_TOP and TCON_LCD clock/reset definesinclude/ | +2 | 0 replies | |
| 15/24 | dt-bindings: display: sun4i: Add compatible strings for H616 DEDocumentation/ | +22 | 0 replies | |
| 16/24 | dt-bindings: display: sun4i: Add compatible strings for H616 TCON TOPDocumentation/ | +9 | 0 replies | |
| 17/24 | dt-bindings: sram: sunxi-sram: Add H616 SRAM C compatibleDocumentation/ | +3 | 0 replies | |
| 18/24 | dt-bindings: display: Add R40 and H616 display engine compatiblesDocumentation/ | +10 | 0 replies | |
| 19/24 | drm/sun4i: tcon: Add support for R40 LCDdrivers/ | +9 | 0 replies | |
| 20/24 | arm64: dts: allwinner: h616: add display engine, bus and mixer nodesarch/ | +59 | 0 replies | |
| 21/24 | arm64: dts: allwinner: h616: Add TCON nodes to H616 DTSIarch/ | +139 | 0 replies | |
| 22/24 | arm64: dts: allwinner: h616: add LCD and LVDS pinsarch/ | +26 | 0 replies | |
| 23/24 | arm64: dts: allwinner: rg35xx: Add GPIO backlight controlarch/ | +6 | 2 replies | |
| 24/24 | arm64: dts: allwinner: rg35xx: Enable LCD outputarch/ | +59 | 0 replies |
Reviews trailers per patch
5 of 24 patches have a Reviewed-by or Acked-by.
| Patch | Andre Przywara | Conor Dooley | Chen-Yu Tsai |
|---|---|---|---|
| 1/24 | R-b | ||
| 2/24 | R-b | ||
| 3/24 | R-b | ||
| 4/24 | R-b | ||
| 5/24 | |||
| 6/24 | |||
| 7/24 | |||
| 8/24 | A-b | R-b | |
| 9/24 | |||
| 10/24 | |||
| 11/24 | |||
| 12/24 | |||
| 13/24 | |||
| 14/24 | |||
| 15/24 | |||
| 16/24 | |||
| 17/24 | |||
| 18/24 | |||
| 19/24 | |||
| 20/24 | |||
| 21/24 | |||
| 22/24 | |||
| 23/24 | |||
| 24/24 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH V9 00/24] drm: sun4i: add Display Engine 3.3 (DE33) support
From: Chris Morgan <[email protected]>
I've spoken with Ryan and he agreed to let me take over this series to get the display engine working on the Allwinner H616. I've taken his previous patch series for Display Engine 3.3 and combined it with the LCD controller patch series. I've also fixed a few additional bugs and made some changes to the device tree bindings.
Changes since V8:
- Combined the DE33 [1] series and the LCD [2] series to better track all patches necessary to output to an LCD display for the Allwinner H700.
- Added a required LVDS reset as requested here [3].
- Added compatible strings with a fallback for allwinner,sun50i-h616-display-engine, allwinner,sun50i-h616-tcon-top, and allwinner,sun50i-h616-sram-c.
- Added binding documentation for the LCD controller.
- Renamed the de3_sram device tree node to de33_sram.
- Corrected the LVDS reset for the LCD controller binding.
- Removed the PWM pins from the pincontroller bindings, as PWM is not yet supported.
- Reordered the patches so that a binding or a device tree node is not referenced before it is defined.
[1] https://lore.kernel.org/linux-sunxi/[email protected]/
[2] https://lore.kernel.org/linux-sunxi/[email protected]/
[3] https://lore.kernel.org/linux-sunxi/38669808.XM6RcZxFsP@jernej-laptop/
Chris Morgan (24):
dt-bindings: clock: sun50i-h616-ccu: Add LVDS reset
clk: sunxi-ng: h616: Add LVDS reset for LCD TCON
drm: sun4i: de2/de3: add mixer version enum
drm: sun4i: de2/de3: refactor mixer initialisation
drm: sun4i: de2/de3: add generic blender register reference function
drm: sun4i: de2/de3: use generic register reference function for layer
configuration
dt-bindings: allwinner: add H616 DE33 bus binding
dt-bindings: allwinner: add H616 DE33 clock binding
dt-bindings: allwinner: add H616 DE33 mixer binding
clk: sunxi-ng: ccu: add Display Engine 3.3 (DE33) support
drm: sun4i: de33: vi_scaler: add Display Engine 3.3 (DE33) support
drm: sun4i: de33: mixer: add Display Engine 3.3 (DE33) support
drm: sun4i: de33: mixer: add mixer configuration for the H616
dt-bindings: allwinner: Add TCON_TOP and TCON_LCD clock/reset defines
dt-bindings: display: sun4i: Add compatible strings for H616 DE
dt-bindings: display: sun4i: Add compatible strings for H616 TCON TOP
dt-bindings: sram: sunxi-sram: Add H616 SRAM C compatible
dt-bindings: display: Add R40 and H616 display engine compatibles drm/sun4i: tcon: Add support for R40 LCD
arm64: dts: allwinner: h616: add display engine, bus and mixer nodes
arm64: dts: allwinner: h616: Add TCON nodes to H616 DTSI
arm64: dts: allwinner: h616: add LCD and LVDS pins
arm64: dts: allwinner: rg35xx: Add GPIO backlight control
arm64: dts: allwinner: rg35xx: Enable LCD output
.../bus/allwinner,sun50i-a64-de2.yaml | 7 +- .../clock/allwinner,sun8i-a83t-de2-clk.yaml | 1 + .../allwinner,sun4i-a10-display-engine.yaml | 39 +-- .../display/allwinner,sun4i-a10-tcon.yaml | 10 + .../allwinner,sun8i-a83t-de2-mixer.yaml | 34 ++- .../display/allwinner,sun8i-r40-tcon-top.yaml | 13 +- .../allwinner,sun4i-a10-system-control.yaml | 4 +- .../arm64/boot/dts/allwinner/sun50i-h616.dtsi | 224 ++++++++++++++++++ .../sun50i-h700-anbernic-rg35xx-2024.dts | 64 +++++ drivers/clk/sunxi-ng/ccu-sun50i-h616.c | 1 + drivers/clk/sunxi-ng/ccu-sun8i-de2.c | 25 ++ drivers/gpu/drm/sun4i/sun4i_tcon.c | 9 + drivers/gpu/drm/sun4i/sun8i_csc.c | 4 +- drivers/gpu/drm/sun4i/sun8i_mixer.c | 168 ++++++++++--- drivers/gpu/drm/sun4i/sun8i_mixer.h | 30 ++- drivers/gpu/drm/sun4i/sun8i_ui_layer.c | 27 ++- drivers/gpu/drm/sun4i/sun8i_ui_scaler.c | 2 +- drivers/gpu/drm/sun4i/sun8i_vi_layer.c | 14 +- drivers/gpu/drm/sun4i/sun8i_vi_scaler.c | 6 +- include/dt-bindings/clock/sun8i-tcon-top.h | 2 + include/dt-bindings/reset/sun50i-h616-ccu.h | 1 + 21 files changed, 597 insertions(+), 88 deletions(-)
Signature · 1 line
2.43.0