Skip to content

netfs: Miscellaneous fixes

David Howells ceph-devel linux-cifs linux-erofs linux-fsdevel linux-mm linux-nfs lkml netfs v9fs 1 version Applied

Status from this message: Applied to the vfs.fixes branch of the vfs/vfs.git tree.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 1 replyApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/3netfs: Fix a number of read-retry hangsfs/netfs/read_collect.c fs/netfs/read_retry.c include/linux/netfs.h +1 more+38 -140 replies
2/3netfs: Add retry stat countersfs/netfs/internal.h fs/netfs/read_retry.c fs/netfs/stats.c +2 more+19 -00 replies
3/3netfs: Fix setting NETFS_RREQ_ALL_QUEUED to be after all subreqs queuedfs/netfs/buffered_read.c+13 -60 replies

Reviews trailers per patch

None of the 3 patches has a Reviewed-by or Acked-by.

PatchMarc DionneSteve FrenchIhor Solodrai
1/3T-b T-b
2/3
3/3T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH 0/3] netfs: Miscellaneous fixes

Hi Christian,

Here are some miscellaneous fixes and changes for netfslib, if you could pull them:

(1) Fix a number of read-retry hangs, including:

(a) Incorrect getting/putting of references on subreqs as we retry them.

(b) Failure to track whether a last old subrequest in a retried set is superfluous.

(c) Inconsistency in the usage of wait queues used for subrequests (ie. using clear_and_wake_up_bit() whilst waiting on a private waitqueue).

(Note that waitqueue consistency also needs looking at for netfs_io_request structs.)

(2) Add stats counters for retries and publish in /proc/fs/netfs/stats. This is not a fix per se, but is useful in debugging and shouldn't otherwise change the operation of the code.

(3) Fix the ordering of queuing subrequests with respect to setting the request flag that says we've now queued them all.

The patches can also be found here:

https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/log/?h=netfs-fixes

Thanks,
David

David Howells (3):
netfs: Fix a number of read-retry hangs
netfs: Add retry stat counters
netfs: Fix setting NETFS_RREQ_ALL_QUEUED to be after all subreqs
queued

 fs/netfs/buffered_read.c     | 19 +++++++++++-----
 fs/netfs/internal.h          |  4 ++++
 fs/netfs/read_collect.c      |  6 +++--
 fs/netfs/read_retry.c        | 43 +++++++++++++++++++++++++++---------
 fs/netfs/stats.c             |  9 ++++++++
 fs/netfs/write_issue.c       |  1 +
 fs/netfs/write_retry.c       |  2 ++
 include/linux/netfs.h        |  2 +-
 include/trace/events/netfs.h |  4 +++-
 9 files changed, 70 insertions(+), 20 deletions(-)