Skip to content

drm/mediatek: Add PQ components support for MT8196

Jay Liu dri-devel linux-arm-kernel linux-devicetree linux-mediatek lkml 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest6 patches 6 repliesIn review
  2. v46 patches 3 repliesSuperseded
  3. v36 patches 6 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v27 patches16 repliesSuperseded
v17 patches14 repliesSuperseded

Changes in v5 from the cover letter

- Cover letter: Fix subject spelling and add subsystem prefix
- tdshp dt-binding: Replace 'disp-tdshp' with 'tdshp' in dt-binding (suggested by Krzysztof)
- Add complete version history and lore links for tracking (suggested by Krzysztof)

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6dt-bindings: display: mediatek: gamma: Add support for MT8196Documentation/devicetree/bindings/display/mediatek/mediatek,gamma.yaml+1 -01 reply
2/6dt-bindings: display: mediatek: dither: Add support for MT8196Documentation/devicetree/bindings/display/mediatek/mediatek,dither.yaml+1 -01 reply
3/6dt-bindings: display: mediatek: ccorr: Add support for MT8196Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr.yaml+1 -01 reply
4/6dt-bindings: display: mediatek: tdshp: Add support for MT8196Documentation/devicetree/bindings/display/mediatek/mediatek,tdshp.yaml+46 -02 replies
5/6drm/mediatek: Support multiple CCORR componentdrivers/gpu/drm/mediatek/mtk_crtc.c drivers/gpu/drm/mediatek/mtk_ddp_comp.c drivers/gpu/drm/mediatek/mtk_ddp_comp.h +2 more+15 -81 reply
6/6drm/mediatek: Add TDSHP component support for MT8196drivers/gpu/drm/mediatek/mtk_ddp_comp.c drivers/gpu/drm/mediatek/mtk_ddp_comp.h drivers/gpu/drm/mediatek/mtk_drm_drv.c+52 -00 replies

Reviews trailers per patch

5 of 6 patches have a Reviewed-by or Acked-by.

PatchAngeloGioacchino Del RegnoKrzysztof KozlowskiCK Hu
1/6R-b A-b R-b
2/6R-b A-b R-b
3/6R-b A-b R-b
4/6
5/6R-b R-b
6/6R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v5 thread

Cover letter [PATCH v5 0/6] drm/mediatek: Add PQ components support for MT8196

This series adds Picture Quality (PQ) component support for the MT8196 SoC, including device tree bindings and driver implementations for GAMMA, DITHER, CCORR, and TDSHP modules.

Patch 1: Add GAMMA compatible string for MT8196 Patch 2: Add DITHER compatible string for MT8196 Patch 3: Add CCORR compatible string for MT8196 Patch 4: Add TDSHP dt-binding documentation Patch 5: Add support for multiple CCORR components Patch 6: Add TDSHP driver support for MT8196

Architecture notes:
MT8196 display pipeline includes two CCORR instances that must be chained in the hardware path, but the CTM API only configures one. Patch 5 ensures the second CCORR instance does not interfere with the configured one.

Testing:
- Verified dt-bindings pass dt_binding_check
- Tested display pipeline with all PQ components on MT8196 EVB
- Confirmed color correction (CCORR CTM and GAMMA LUT) functionality
- Confirmed sharpness enhancement (TDSHP) functionality in relay mode
- Note: dtbs_check will be validated when MT8196 DTS is upstreamed

Changes in v5:
- Cover letter: Fix subject spelling and add subsystem prefix
- tdshp dt-binding: Replace 'disp-tdshp' with 'tdshp' in dt-binding (suggested by Krzysztof)
- Add complete version history and lore links for tracking (suggested by Krzysztof)

Changes in v4:
- tdshp dt-binding: Remove unused 'Sibling' description (suggested by Krzysztof)
- tdshp dt-binding: Use enum directly instead of items list for compatible property
- tdshp dt-binding: Fix indentation and remove extra blank line in example section
- ccorr driver: Rebase on linux-next to resolve conflicts

Changes in v3:
- Fix dt_binding_check errors in all binding patches
- Remove incorrect Signed-off-by line
- Move standalone ccorr fix out of this series

Changes in v2:
- Optimize ccorr ctm_set process to avoid affecting other SoCs
- Remove unnecessary code from tdshp driver
- Update tdshp dt-bindings (clocks, description, examples)

Link to v4: https://lore.kernel.org/all/[email protected]/
Link to v3: https://lore.kernel.org/all/[email protected]/
Link to v2: https://lore.kernel.org/all/[email protected]/
Link to v1: https://lore.kernel.org/all/[email protected]/

Dependencies:
This series depends on the MT8196 display pipeline foundation patches [1].

[1] "Add display path components support for MT8196"

    https://patchwork.kernel.org/project/linux-mediatek/list/?series=955361

Jay Liu (6):
dt-bindings: display: mediatek: gamma: Add support for MT8196
dt-bindings: display: mediatek: dither: Add support for MT8196
dt-bindings: display: mediatek: ccorr: Add support for MT8196
dt-bindings: display: mediatek: tdshp: Add support for MT8196 drm/mediatek: Support multiple CCORR component drm/mediatek: Add TDSHP component support for MT8196

 .../display/mediatek/mediatek,ccorr.yaml      |  1 +
 .../display/mediatek/mediatek,dither.yaml     |  1 +
 .../display/mediatek/mediatek,gamma.yaml      |  1 +
 .../display/mediatek/mediatek,tdshp.yaml      | 46 ++++++++++++++++
 drivers/gpu/drm/mediatek/mtk_crtc.c           |  5 +-
 drivers/gpu/drm/mediatek/mtk_ddp_comp.c       | 52 ++++++++++++++++++-
 drivers/gpu/drm/mediatek/mtk_ddp_comp.h       |  8 +--
 drivers/gpu/drm/mediatek/mtk_disp_ccorr.c     |  6 ++-
 drivers/gpu/drm/mediatek/mtk_disp_drv.h       |  2 +-
 drivers/gpu/drm/mediatek/mtk_drm_drv.c        |  2 +
 10 files changed, 116 insertions(+), 8 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/display/mediatek/mediatek,tdshp.yaml
Signature · 1 line
2.46.0