Skip to content

ASoC: codecs: Update device_id tables for Realtek drivers

Cezary Rojewski linux-sound 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest22 patches 3 repliesIn review
  2. v124 patches 12 repliesSuperseded

Changes in v2 from the cover letter

- dropped 2 conflicting patches for rt1015p and rt5682s as pointed out by Choiu and Shuming
- sorted ACPI IDs alphabetically as suggested by Andy. This targets numerous patches and is noted by 'While at it, sort the IDs alphabetically.' in the commit message
- spacing (whitespaces) should now be cohesive across all patches

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/22ASoC: codecs: rt1011: Fix definition of device_id tablessound/soc/codecs/rt1011.c+3 -30 replies
2/22ASoC: codecs: rt1015: Fix definition of device_id tablessound/soc/codecs/rt1015.c+3 -30 replies
3/22ASoC: codecs: rt1016: Fix definition of device_id tablessound/soc/codecs/rt1016.c+3 -30 replies
4/22ASoC: codecs: rt1019: Fix definition of device_id tablessound/soc/codecs/rt1019.c+3 -30 replies
5/22ASoC: codecs: rt1305: Fix definition of device_id tablessound/soc/codecs/rt1305.c+4 -40 replies
6/22ASoC: codecs: rt1308: Fix definition of device_id tablessound/soc/codecs/rt1308.c+3 -30 replies
7/22ASoC: codecs: rt1318: Fix definition of device_id tablessound/soc/codecs/rt1318.c+3 -30 replies
8/22ASoC: codecs: rt274: Fix definition of device_id tablessound/soc/codecs/rt274.c+4 -40 replies
9/22ASoC: codecs: rt5514: Fix definition of device_id tablessound/soc/codecs/rt5514.c+3 -30 replies
10/22ASoC: codecs: rt5640: Fix definition of device_id tablessound/soc/codecs/rt5640.c+7 -70 replies
11/22ASoC: codecs: rt5645: Fix definition of device_id tablessound/soc/codecs/rt5645.c+6 -60 replies
12/22ASoC: codecs: rt5651: Fix definition of device_id tablessound/soc/codecs/rt5651.c+4 -40 replies
13/22ASoC: codecs: rt5659: Fix definition of device_id tablessound/soc/codecs/rt5659.c+4 -40 replies
14/22ASoC: codecs: rt5660: Fix definition of device_id tablessound/soc/codecs/rt5660.c+4 -40 replies
15/22ASoC: codecs: rt5663: Fix definition of device_id tablessound/soc/codecs/rt5663.c+3 -30 replies
16/22ASoC: codecs: rt5665: Fix definition of device_id tablessound/soc/codecs/rt5665.c+4 -40 replies
17/22ASoC: codecs: rt5668: Fix definition of device_id tablessound/soc/codecs/rt5668.c+3 -30 replies
18/22ASoC: codecs: rt5670: Fix definition of device_id tablessound/soc/codecs/rt5670.c+4 -40 replies
19/22ASoC: codecs: rt5682: Fix definition of device_id tablessound/soc/codecs/rt5682-i2c.c+3 -30 replies
20/22ASoC: codecs: rt286: Update definition of device_id tablessound/soc/codecs/rt286.c+3 -20 replies
21/22ASoC: codecs: rt298: Update definition of device_id tablessound/soc/codecs/rt298.c+3 -20 replies
22/22ASoC: codecs: rt5677: Update definition of device_id tablessound/soc/codecs/rt5677-spi.c sound/soc/codecs/rt5677.c+3 -11 reply

Reviews trailers per patch

None of the 22 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchAndy Shevchenko
SeriesR-b
1/22
2/22
3/22
4/22
5/22
6/22
7/22
8/22
9/22
10/22
11/22
12/22
13/22
14/22
15/22
16/22
17/22
18/22
19/22
20/22
21/22
22/22

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 00/22] ASoC: codecs: Update device_id tables for Realtek drivers

The series aims to streamline the formatting for ACPI IDs so that a single pattern can be used to identify the device.

Work implicitly suggested by Andy Shevchenko - reading and learning from number of his reviews on the Linux mailing lists.

Several formats do exists, however, after technical discussion PCI-based format has been selected as the recommended one. For Realtek devices, it is going to be 10ECxxxx where 10EC unambiguously identifies Realtek company whereas the following 4 hexes specify the PART_ID i.e.: the device.

While at it, there shall be no comma after the terminator entry and initializing fields with 0 for statically defined structs is redundant.

Patches sorted into two groups:
- fixes, no functional changes
- updates: fix + addition of new ACPI ID entries

Changes in v2:
- dropped 2 conflicting patches for rt1015p and rt5682s as pointed out by Choiu and Shuming
- sorted ACPI IDs alphabetically as suggested by Andy. This targets numerous patches and is noted by 'While at it, sort the IDs alphabetically.' in the commit message
- spacing (whitespaces) should now be cohesive across all patches

Cezary Rojewski (22):
ASoC: codecs: rt1011: Fix definition of device_id tables
ASoC: codecs: rt1015: Fix definition of device_id tables
ASoC: codecs: rt1016: Fix definition of device_id tables
ASoC: codecs: rt1019: Fix definition of device_id tables
ASoC: codecs: rt1305: Fix definition of device_id tables
ASoC: codecs: rt1308: Fix definition of device_id tables
ASoC: codecs: rt1318: Fix definition of device_id tables
ASoC: codecs: rt274: Fix definition of device_id tables
ASoC: codecs: rt5514: Fix definition of device_id tables
ASoC: codecs: rt5640: Fix definition of device_id tables
ASoC: codecs: rt5645: Fix definition of device_id tables
ASoC: codecs: rt5651: Fix definition of device_id tables
ASoC: codecs: rt5659: Fix definition of device_id tables
ASoC: codecs: rt5660: Fix definition of device_id tables
ASoC: codecs: rt5663: Fix definition of device_id tables
ASoC: codecs: rt5665: Fix definition of device_id tables
ASoC: codecs: rt5668: Fix definition of device_id tables
ASoC: codecs: rt5670: Fix definition of device_id tables
ASoC: codecs: rt5682: Fix definition of device_id tables
ASoC: codecs: rt286: Update definition of device_id tables
ASoC: codecs: rt298: Update definition of device_id tables
ASoC: codecs: rt5677: Update definition of device_id tables

 sound/soc/codecs/rt1011.c     |  6 +++---
 sound/soc/codecs/rt1015.c     |  6 +++---
 sound/soc/codecs/rt1016.c     |  6 +++---
 sound/soc/codecs/rt1019.c     |  6 +++---
 sound/soc/codecs/rt1305.c     |  8 ++++----
 sound/soc/codecs/rt1308.c     |  6 +++---
 sound/soc/codecs/rt1318.c     |  6 +++---
 sound/soc/codecs/rt274.c      |  8 ++++----
 sound/soc/codecs/rt286.c      |  5 +++--
 sound/soc/codecs/rt298.c      |  5 +++--
 sound/soc/codecs/rt5514.c     |  6 +++---
 sound/soc/codecs/rt5640.c     | 14 +++++++-------
 sound/soc/codecs/rt5645.c     | 12 ++++++------
 sound/soc/codecs/rt5651.c     |  8 ++++----
 sound/soc/codecs/rt5659.c     |  8 ++++----
 sound/soc/codecs/rt5660.c     |  8 ++++----
 sound/soc/codecs/rt5663.c     |  6 +++---
 sound/soc/codecs/rt5665.c     |  8 ++++----
 sound/soc/codecs/rt5668.c     |  6 +++---
 sound/soc/codecs/rt5670.c     |  8 ++++----
 sound/soc/codecs/rt5677-spi.c |  3 ++-
 sound/soc/codecs/rt5677.c     |  1 +
 sound/soc/codecs/rt5682-i2c.c |  6 +++---
 23 files changed, 80 insertions(+), 76 deletions(-)
Signature · 1 line
2.25.1