Fix Compilation Error on Android and Some Cleanup
Status from this message: Applied, thanks!
Get series with b4
b4 am [email protected]Versions newest first
Patches in v1 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | liburing.h: Remove redundant double negationsrc/ | +1 | 0 replies | |
| 2/3 | liburing.h: Explain the history of `io_uring_get_sqe()`src/ | +19 | 0 replies | |
| 3/3 | Fix missing `aligned_alloc()` on some Android devicesexamples/ examples/ examples/ +2 more | +37 | 0 replies |
Reviews trailers per patch
None of the 3 patches has a Reviewed-by or Acked-by.
| Patch | Alviro Iskandar Setiawan |
|---|---|
| 1/3 | |
| 2/3 | |
| 3/3 | Co-authored-by |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH liburing v1 0/3] Fix Compilation Error on Android and Some Cleanup
Hi Jens,
Another day in the thrilling world of cross-platform compatibility...
Alviro discovered that some Android versions are missing aligned_alloc() in <stdlib.h>, leading to a compilation error on Termux 0.118.0:
```
cmd-discard.c:383:11: warning: call to undeclared library function \
'aligned_alloc' with type 'void *(unsigned long, unsigned long)'; ISO \
C99 and later do not support implicit function declarations \
[-Wimplicit-function-declaration]
buffer = aligned_alloc(lba_size, lba_size);
^
```To resolve this without rewriting large portions of liburing tests, introduce a helper function that wraps posix_memalign() and provides our own aligned_alloc().
While we're at it, there's a redundant double negation lurking in liburing.h. Let's clean that up too.
Also, to prevent yet another round of confusion like what happened in PR #1336, document the history of io_uring_get_sqe() in the header file.
Ref: https://github.com/axboe/liburing/pull/1336
---
Ammar Faizi (3):
liburing.h: Remove redundant double negation liburing.h: Explain the history of io_uring_get_sqe() Fix missing aligned_alloc() on some Android devices
examples/helpers.c | 10 ++++++++++ examples/helpers.h | 7 +++++++ examples/reg-wait.c | 2 ++ src/include/liburing.h | 21 ++++++++++++++++++++- test/helpers.c | 10 ++++++++++ test/helpers.h | 8 ++++++++ 6 files changed, 57 insertions(+), 1 deletion(-)
base-commit: 66b071d1470ae787d47d4cb8d9cb3836249baf61
Signature · 1 line
Ammar Faizi