Skip to content

arm64: sunxi: h616: Enable Mali GPU

Andre Przywara linux-arm-kernel linux-devicetree linux-pm linux-sunxi 2 versions – Applied

Status from this message: Applied to dt-for-6.16 in [email protected]:linux-sunxi/linux-sunxi.git, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 5 repliesApplied
  2. v15 patches 10 repliesApplied

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/4dt-bindings: power: Add Allwinner H6/H616 PRCM PPUDocumentation/devicetree/bindings/power/allwinner,sun50i-h6-prcm-ppu.yaml+42 -03 replies
2/4pmdomain: sunxi: add H6 PRCM PPU driverdrivers/pmdomain/sunxi/Kconfig drivers/pmdomain/sunxi/Makefile drivers/pmdomain/sunxi/sun50i-h6-prcm-ppu.c+219 -01 reply
3/4arm64: dts: allwinner: h616: Add Mali GPU nodearch/arm64/boot/dts/allwinner/sun50i-h616.dtsi+21 -00 replies
4/4arm64: dts: allwinner: h616: enable Mali GPU for all boardsarch/arm64/boot/dts/allwinner/sun50i-h313-tanix-tx1.dts arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-cb1.dtsi arch/arm64/boot/dts/allwinner/sun50i-h616-orangepi-zero.dtsi +7 more+47 -00 replies

Reviews trailers per patch

3 of 4 patches have a Reviewed-by or Acked-by.

PatchRob Herring (Arm)Jernej Skrabec
1/4R-b
2/4
3/4R-b
4/4A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/4] arm64: sunxi: h616: Enable Mali GPU

Hi,

version 2 is addressing the comments I got from the reviewers (many thanks for that!). The list of power domains is now separated from the per-SoC data, to avoid going over the list twice. Also the error path takes care of removing already registered genpd objects. Based on v6.15-rc1, changelog below.

==========================
The Allwinner H616/H618/H313/H700 SoCs contain a Mali G32 MP2 GPU. This IP is from the Bifrost family and is already supported by the panfrost driver, so enabling support for 3D graphics on this SoC is rather straight-forward.
However Allwinner added some bits in the PRCM block, that control the power domain for the GPU - on top of its power *supply*.

This series enables the Mali GPU on those SoCs, by first introducing a power domain driver for that SoC (patch 1/4: DT binding, patch 2/4:
the actual driver). For the Mali GPU to work we literally need to flip a single bit (the BSP does this in the bootloader), and this full featured power domain driver is admittedly a bit over the top for that purpose. However it seems to be the right thing to do architecturally, and while at it I added the other power domains (for analogue, PLLs, and the management core), even though we won't use them in Linux and they would be always on.

The rest of the patches enable the Mali GPU on the DT side: patch 3/4 adds the purely SoC specific DT nodes, for both the power domain and the Mali GPU. The final patch 4/4 then enables the GPU on all existing H616-family boards.

For this to reliably work, the Panfrost driver needs a tweak to fix the order of clock and reset bring-up and tear-down[1], but this is technically independent from this series.

Cheers,
Andre

[1] https://lore.kernel.org/linux-sunxi/[email protected]/

Changelog v1 .. v2:
- rebase on v6.15-rc1
- drop already applied Allwinner Mali DT binding patch
- add review tags
- move list of power domains into separate structs, use ARRAY_SIZE()
- remove already registered genpds in error path
- print correct power domain name in error path

Andre Przywara (4):
dt-bindings: power: Add Allwinner H6/H616 PRCM PPU
pmdomain: sunxi: add H6 PRCM PPU driver
arm64: dts: allwinner: h616: Add Mali GPU node
arm64: dts: allwinner: h616: enable Mali GPU for all boards

 .../power/allwinner,sun50i-h6-prcm-ppu.yaml   |  42 ++++
 .../dts/allwinner/sun50i-h313-tanix-tx1.dts   |   5 +
 .../sun50i-h616-bigtreetech-cb1.dtsi          |   5 +
 .../allwinner/sun50i-h616-orangepi-zero.dtsi  |   4 +
 .../allwinner/sun50i-h616-orangepi-zero2.dts  |   4 +
 .../dts/allwinner/sun50i-h616-x96-mate.dts    |   5 +
 .../arm64/boot/dts/allwinner/sun50i-h616.dtsi |  21 ++
 .../sun50i-h618-longan-module-3h.dtsi         |   5 +
 .../allwinner/sun50i-h618-orangepi-zero2w.dts |   5 +
 .../allwinner/sun50i-h618-orangepi-zero3.dts  |   4 +
 .../sun50i-h618-transpeed-8k618-t.dts         |   5 +
 .../sun50i-h700-anbernic-rg35xx-2024.dts      |   5 +
 drivers/pmdomain/sunxi/Kconfig                |  10 +
 drivers/pmdomain/sunxi/Makefile               |   1 +
 drivers/pmdomain/sunxi/sun50i-h6-prcm-ppu.c   | 208 ++++++++++++++++++
 15 files changed, 329 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/power/allwinner,sun50i-h6-prcm-ppu.yaml
 create mode 100644 drivers/pmdomain/sunxi/sun50i-h6-prcm-ppu.c
Signature · 1 line
2.46.3