Skip to content

trace: add tracepoint for tcp_sendmsg_locked()

Breno Leitao linux-trace-kernel lkml netdev 3 versions – Applied

Status from this message: This series was applied to netdev/net-next.git (main)

Get series with b4
b4 am [email protected] change-id 20250224-tcpsendmsg-4f0a236751d7

Versions newest first

  1. v3 Latest2 patches 3 repliesApplied 2/2
  2. v22 patches 9 repliesSuperseded
  3. v11 patch 17 repliesSuperseded

Changes in v3 from the cover letter

- Fixed identation (Kuniyuki Iwashi)
- Removed duplicated entry in the commit message (Kuniyuki Iwashi)
- Added tcp_sendmsg_locked in bpf_raw_tp_null_args[] (Kuniyuki Iwashi)
- Link to v2: https://lore.kernel.org/r/[email protected]

Patches in v3 All 2 applied

#Subject and filesSizeRepliesApplied
1/2net: pass const to msg_data_left()include/linux/socket.h+1 -10 repliesApplied
2/2trace: tcp: Add tracepoint for tcp_sendmsg_locked()include/trace/events/tcp.h kernel/bpf/btf.c net/ipv4/tcp.c+27 -03 repliesApplied

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchKuniyuki IwashimaEric DumazetDavid Ahern
1/2R-b R-b
2/2R-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v3 thread

Cover letter [PATCH net-next v3 0/2] trace: add tracepoint for tcp_sendmsg_locked()

Meta has been using BPF programs to monitor tcp_sendmsg() for years, indicating significant interest in observing this important functionality. Adding a proper tracepoint provides a stable API for all users who need visibility into TCP message transmission.

David Ahern is using a similar functionality with a custom patch[1]. So, this means we have more than a single use case for this request, and it might be a good idea to have such feature upstream.

---
Changes in v3:
- Fixed identation (Kuniyuki Iwashi)
- Removed duplicated entry in the commit message (Kuniyuki Iwashi)
- Added tcp_sendmsg_locked in bpf_raw_tp_null_args[] (Kuniyuki Iwashi)
- Link to v2: https://lore.kernel.org/r/[email protected]

Changes in v2:
- Change to a full tracepoint inside tcp_sendmsg_locked(), heavily inspired in David's patch
- Link to v1: https://lore.kernel.org/r/[email protected]

---
Breno Leitao (2):
net: pass const to msg_data_left()
trace: tcp: Add tracepoint for tcp_sendmsg_locked()

 include/linux/socket.h     |  2 +-
 include/trace/events/tcp.h | 24 ++++++++++++++++++++++++
 kernel/bpf/btf.c           |  1 +
 net/ipv4/tcp.c             |  2 ++
 4 files changed, 28 insertions(+), 1 deletion(-)

---
base-commit: 1a9239bb4253f9076b5b4b2a1a4e8d7defd77a95
change-id: 20250224-tcpsendmsg-4f0a236751d7

Best regards,

Signature · 1 line
Breno Leitao <[email protected]>