Skip to content

Fix ntuple rules targeting default RSS

Gal Pressman linux-kselftest netdev 3 versions – Applied

Status from this message: This series was applied to netdev/net.git (main)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 1 replyApplied 2/2
  2. v22 patches 7 repliesSuperseded
  3. v11 patch 15 repliesSuperseded

Patches in v3 All 2 applied

#Subject and filesSizeRepliesApplied
1/2net: ethtool: Don't check if RSS context exists in case of context 0net/ethtool/ioctl.c+2 -11 replyApplied
2/2selftests: drv-net: rss_ctx: Add test for ntuple rules targeting default RSS contexttools/testing/selftests/drivers/net/hw/rss_ctx.py+58 -10 repliesApplied

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchTariq ToukanNimrod OrenJoe DamatoEdward Cree
1/2R-b R-b R-b R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v3 thread

Cover letter [PATCH net v3 0/2] Fix ntuple rules targeting default RSS

This series addresses a regression in ethtool flow steering where rules targeting the default RSS context (context 0) were incorrectly rejected.

The default RSS context always exists but is not stored in the rss_ctx xarray like additional contexts. The current validation logic was checking for the existence of context 0 in this array, causing valid flow steering rules to be rejected.

This prevented configurations such as:
- High priority rules directing specific traffic to the default context
- Low priority catch-all rules directing remaining traffic to additional contexts

Patch 1 fixes the validation logic to skip the existence check for context 0.

Patch 2 adds a selftest that verifies this behavior.

Changelog -
v2->v3: https://lore.kernel.org/all/[email protected]/
* Reworded commit message.
* Fix pylint warning.

v1->v2: https://lore.kernel.org/all/[email protected]/
* Reworded commit message.
* Added a selftest.

Gal Pressman (2):
net: ethtool: Don't check if RSS context exists in case of context 0
selftests: drv-net: rss_ctx: Add test for ntuple rules targeting
default RSS context

 net/ethtool/ioctl.c                           |  3 +-
 .../selftests/drivers/net/hw/rss_ctx.py       | 59 ++++++++++++++++++-
 2 files changed, 60 insertions(+), 2 deletions(-)
Signature · 1 line
2.40.1