Skip to content

ALSA: cs35l56: Fix for races when soft-resetting on SPI

Richard Fitzgerald linux-sound lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2firmware: cs_dsp: Remove async regmap writesdrivers/firmware/cirrus/cs_dsp.c+6 -183 replies
2/2ASoC: cs35l56: Prevent races when soft-resetting using SPI controlinclude/sound/cs35l56.h sound/pci/hda/cs35l56_hda_spi.c sound/soc/codecs/cs35l56-shared.c +1 more+117 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] ALSA: cs35l56: Fix for races when soft-resetting on SPI

These two patches fix a race condition between driver and amp when issuing a soft-reset over SPI. The main problem with the race is that the driver could read the amp status as fully booted, when in fact the amp is about to reset or is in the process of resetting.

This is mainly contained within the ASoC driver code but a small change is needed to the HDA driver.

The first patch, to cs_dsp, is to remove async regmap writes so that the cs35l56 driver can call spi_bus_lock() without breaking firmware download to other amps on the same SPI bus.

Richard Fitzgerald (2):
firmware: cs_dsp: Remove async regmap writes
ASoC: cs35l56: Prevent races when soft-resetting using SPI control

 drivers/firmware/cirrus/cs_dsp.c  | 24 +++-------
 include/sound/cs35l56.h           | 31 ++++++++++++
 sound/pci/hda/cs35l56_hda_spi.c   |  3 ++
 sound/soc/codecs/cs35l56-shared.c | 80 +++++++++++++++++++++++++++++++
 sound/soc/codecs/cs35l56-spi.c    |  3 ++
 5 files changed, 123 insertions(+), 18 deletions(-)
Signature · 1 line
2.39.5