Skip to content

ipv4: fib: Convert RTM_NEWROUTE and RTM_DELROUTE to per-netns RTNL.

Kuniyuki Iwashima netdev 3 versions – Applied

Status from this message: This series was applied to netdev/net-next.git (main)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest12 patches 2 repliesApplied 12/12
  2. v212 patches 4 repliesSuperseded
  3. v112 patches 18 repliesSuperseded

Changes in v3 from the cover letter

* Add Eric's and David's tags
* Patch 2
* Use kvcalloc() instead of kvmalloc_array(, __GFP_ZERO)

Patches in v3 All 12 applied

#Subject and filesSizeRepliesApplied
1/12ipv4: fib: Use cached net in fib_inetaddr_event().net/ipv4/fib_frontend.c+2 -20 repliesApplied
2/12ipv4: fib: Allocate fib_info_hash[] and fib_info_laddrhash[] by kvcalloc().net/ipv4/fib_semantics.c+25 -180 repliesApplied
3/12ipv4: fib: Allocate fib_info_hash[] during netns initialisation.include/net/ip_fib.h net/ipv4/fib_frontend.c net/ipv4/fib_semantics.c+45 -130 repliesApplied
4/12ipv4: fib: Make fib_info_hashfn() return struct hlist_head.net/ipv4/fib_semantics.c+9 -190 repliesApplied
5/12ipv4: fib: Remove fib_info_laddrhash pointer.net/ipv4/fib_semantics.c+11 -160 repliesApplied
6/12ipv4: fib: Remove fib_info_hash_size.net/ipv4/fib_semantics.c+6 -110 repliesApplied
7/12ipv4: fib: Add fib_info_hash_grow().net/ipv4/fib_semantics.c+41 -440 repliesApplied
8/12ipv4: fib: Namespacify fib_info hash tables.include/net/netns/ipv4.h net/ipv4/fib_semantics.c+29 -350 repliesApplied
9/12ipv4: fib: Hold rtnl_net_lock() for ip_fib_net_exit().net/ipv4/fib_frontend.c+7 -50 repliesApplied
10/12ipv4: fib: Hold rtnl_net_lock() in ip_rt_ioctl().net/ipv4/fib_frontend.c+4 -60 repliesApplied
11/12ipv4: fib: Move fib_valid_key_len() to rtm_to_fib_config().net/ipv4/fib_frontend.c net/ipv4/fib_trie.c+16 -240 repliesApplied
12/12ipv4: fib: Convert RTM_NEWROUTE and RTM_DELROUTE to per-netns RTNL.net/ipv4/fib_frontend.c+14 -50 repliesApplied

Reviews trailers per patch

All 12 patches have a Reviewed-by or Acked-by.

PatchEric DumazetDavid Ahern
1/12R-b R-b
2/12R-b R-b
3/12R-b R-b
4/12R-b R-b
5/12R-b R-b
6/12R-b R-b
7/12R-b R-b
8/12R-b R-b
9/12R-b R-b
10/12R-b R-b
11/12R-b R-b
12/12R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 net-next 00/12] ipv4: fib: Convert RTM_NEWROUTE and RTM_DELROUTE to per-netns RTNL.

Patch 1 is misc cleanup.
Patch 2 ~ 8 converts two fib_info hash tables to per-netns. Patch 9 ~ 12 converts rtnl_lock() to rtnl_net_lcok().

Changes:
v3:
* Add Eric's and David's tags
* Patch 2
* Use kvcalloc() instead of kvmalloc_array(, __GFP_ZERO)

v2: https://lore.kernel.org/netdev/[email protected]/
* Add Eric's tag except for patch 3 (due to a minor change for exit_batch())
* Patch 3
* Fix memleak by calling fib4_semantics_exit() properly
* Move fib4_semantics_exit() to fib_net_exit_batch()

v1: https://lore.kernel.org/netdev/[email protected]/

Kuniyuki Iwashima (12):
ipv4: fib: Use cached net in fib_inetaddr_event().
ipv4: fib: Allocate fib_info_hash[] and fib_info_laddrhash[] by

    kvcalloc().

ipv4: fib: Allocate fib_info_hash[] during netns initialisation.
ipv4: fib: Make fib_info_hashfn() return struct hlist_head.
ipv4: fib: Remove fib_info_laddrhash pointer.
ipv4: fib: Remove fib_info_hash_size.
ipv4: fib: Add fib_info_hash_grow().
ipv4: fib: Namespacify fib_info hash tables.
ipv4: fib: Hold rtnl_net_lock() for ip_fib_net_exit().
ipv4: fib: Hold rtnl_net_lock() in ip_rt_ioctl().
ipv4: fib: Move fib_valid_key_len() to rtm_to_fib_config().
ipv4: fib: Convert RTM_NEWROUTE and RTM_DELROUTE to per-netns RTNL.

 include/net/ip_fib.h     |   2 +
 include/net/netns/ipv4.h |   3 +
 net/ipv4/fib_frontend.c  |  74 ++++++++++----
 net/ipv4/fib_semantics.c | 206 +++++++++++++++++++--------------------
 net/ipv4/fib_trie.c      |  22 -----
 5 files changed, 159 insertions(+), 148 deletions(-)
Signature · 1 line
2.39.5 (Apple Git-154)