Skip to content

Add missing netlink error message macros to coccinelle test

Gal Pressman netdev 1 version Applied

Status from this message: This series was applied to netdev/net-next.git (main)

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 2 repliesApplied 5/5

Patches in v1 All 5 applied

#Subject and filesSizeRepliesApplied
1/5coccinelle: Add missing (GE)NL_SET_ERR_MSG_* to strings ending with newline testscripts/coccinelle/misc/newline_in_nl_msg.cocci+8 -50 repliesApplied
2/5net/mlx5: Remove newline at the end of a netlink error messagedrivers/net/ethernet/mellanox/mlx5/core/dpll.c drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun_vxlan.c drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c +1 more+6 -60 repliesApplied
3/5sfc: Remove newline at the end of a netlink error messagedrivers/net/ethernet/sfc/mae.c drivers/net/ethernet/sfc/tc.c+4 -40 repliesApplied
4/5net: sched: Remove newline at the end of a netlink error messagenet/sched/sch_qfq.c+1 -10 repliesApplied
5/5ice: dpll: Remove newline at the end of a netlink error messagedrivers/net/ethernet/intel/ice/ice_dpll.c+7 -71 replyApplied

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchTariq ToukanPrzemek KitszelMichal Swiatkowski
SeriesR-b
1/5R-b
2/5R-b
3/5R-b
4/5R-b
5/5R-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH net-next 0/5] Add missing netlink error message macros to coccinelle test

The newline_in_nl_msg.cocci test is missing some variants in the list of checked macros, add them and fix all reported issues.

Thanks,
Gal

Gal Pressman (5):
coccinelle: Add missing (GE)NL_SET_ERR_MSG_* to strings ending with
newline test
net/mlx5: Remove newline at the end of a netlink error message
sfc: Remove newline at the end of a netlink error message
net: sched: Remove newline at the end of a netlink error message
ice: dpll: Remove newline at the end of a netlink error message

 drivers/net/ethernet/intel/ice/ice_dpll.c          | 14 +++++++-------
 drivers/net/ethernet/mellanox/mlx5/core/dpll.c     |  2 +-
 .../ethernet/mellanox/mlx5/core/en/tc_tun_vxlan.c  |  2 +-
 .../net/ethernet/mellanox/mlx5/core/en_ethtool.c   |  2 +-
 .../net/ethernet/mellanox/mlx5/core/esw/bridge.c   |  6 +++---
 drivers/net/ethernet/sfc/mae.c                     |  2 +-
 drivers/net/ethernet/sfc/tc.c                      |  6 +++---
 net/sched/sch_qfq.c                                |  2 +-
 scripts/coccinelle/misc/newline_in_nl_msg.cocci    | 13 ++++++++-----
 9 files changed, 26 insertions(+), 23 deletions(-)
Signature · 1 line
2.40.1