Skip to content

CCS PLL fixes and improvements

Sakari Ailus linux-media 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest11 patches 3 repliesIn review
  2. v211 patches 20 repliesSuperseded
  3. v17 patches 0 repliesSuperseded

Changes in v3 from the cover letter

- Reword commit messages based on review comments.

- Move the even PLL multiplier flag next to other non-CCS PLL flags.

- Small code readability improvements.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11media: ccs-pll: Start OP pre-PLL multiplier search from correct valuedrivers/media/i2c/ccs-pll.c+2 -00 replies
2/11media: ccs-pll: Start VT pre-PLL multiplier search from correct valuedrivers/media/i2c/ccs-pll.c+2 -00 replies
3/11media: ccs-pll: Check for too high VT PLL multiplier in dual PLL casedrivers/media/i2c/ccs-pll.c+5 -00 replies
4/11media: ccs-pll: Correct the upper limit of maximum op_pre_pll_clk_divdrivers/media/i2c/ccs-pll.c+1 -10 replies
5/11media: ccs-pll: Print a debug message on too high VT PLL OP clockdrivers/media/i2c/ccs-pll.c+5 -40 replies
6/11media: ccs-pll: Drop LINK_DECOUPLED flagdrivers/media/i2c/ccs-pll.c drivers/media/i2c/ccs-pll.h drivers/media/i2c/ccs/ccs-core.c +1 more+2 -60 replies
7/11media: ccs-pll: Print missing PLL flagsdrivers/media/i2c/ccs-pll.c+3 -10 replies
8/11media: ccs-pll: Add a flag for even PLL multipliersdrivers/media/i2c/ccs-pll.c drivers/media/i2c/ccs-pll.h+11 -11 reply
9/11media: ccs-pll: Better validate VT PLL branchdrivers/media/i2c/ccs-pll.c+9 -30 replies
10/11media: ccs-pll: Print PLL calculator flags in the beginningdrivers/media/i2c/ccs-pll.c+6 -10 replies
11/11media: ccs-pll: Document the CCS PLL flagsdrivers/media/i2c/ccs-pll.c drivers/media/i2c/ccs-pll.h+25 -44 replies

Reviews trailers per patch

All 11 patches have a Reviewed-by or Acked-by.

PatchLaurent Pinchart
1/11R-b
2/11R-b
3/11R-b
4/11R-b
5/11R-b
6/11R-b
7/11R-b
8/11R-b
9/11R-b
10/11R-b
11/11R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 00/11] CCS PLL fixes and improvements

Hi all,

Here are a few fixes and improvements to the CCS PLL calculator.

v2 is <[email protected]>.

v1 is <[email protected]>.

since v2:

- Reword commit messages based on review comments.

- Move the even PLL multiplier flag next to other non-CCS PLL flags.

- Small code readability improvements.

since v1:

- Added patches for the following:

- Drop the now-unused LINK_DECOUPLED flag.

- Print missing flags.

- Print PLL calculator flags before running the calculator (earlier version posted separately already).

- Document the CCS PLL flags tersely but still in a way that is useful.

- Rebased other patches to clean up things first.

Sakari Ailus (11):
media: ccs-pll: Start OP pre-PLL multiplier search from correct value
media: ccs-pll: Start VT pre-PLL multiplier search from correct value
media: ccs-pll: Check for too high VT PLL multiplier in dual PLL case
media: ccs-pll: Correct the upper limit of maximum op_pre_pll_clk_div
media: ccs-pll: Print a debug message on too high VT PLL OP clock
media: ccs-pll: Drop LINK_DECOUPLED flag
media: ccs-pll: Print missing PLL flags
media: ccs-pll: Add a flag for even PLL multipliers
media: ccs-pll: Better validate VT PLL branch
media: ccs-pll: Print PLL calculator flags in the beginning
media: ccs-pll: Document the CCS PLL flags

 drivers/media/i2c/ccs-pll.c       | 49 +++++++++++++++++++++++++------
 drivers/media/i2c/ccs-pll.h       | 29 +++++++++++++++---
 drivers/media/i2c/ccs/ccs-core.c  |  1 -
 drivers/media/i2c/ccs/ccs-quirk.c |  3 +-
 4 files changed, 66 insertions(+), 16 deletions(-)
Signature · 1 line
2.39.5