Skip to content

drm/xe: Fix userptr races and missed validations

Thomas Hellström intel-xe stable 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 1 replyIn review
  2. v14 patches 6 repliesSuperseded

Changes in v2 from the cover letter

- Fix an unintended Fallthrough (Matt Brost)
- Don't recommend backport of Patch2 for older kernels than 6.12+ (Lucas)
- Update the locking requirement docs and asserts for forced invalidations

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4drm/xe/vm: Validate userptr during gpu vma prefetchingdrivers/gpu/drm/xe/xe_vm.c+10 -11 reply
2/4drm/xe/vm: Fix a misplaced #endifdrivers/gpu/drm/xe/xe_vm.h+1 -10 replies
3/4drm/xe: Fix fault mode invalidation with unbinddrivers/gpu/drm/xe/xe_pt.c drivers/gpu/drm/xe/xe_vm.c drivers/gpu/drm/xe/xe_vm.h +1 more+75 -600 replies
4/4drm/xe: Add staging tree for VM bindsdrivers/gpu/drm/xe/xe_pt.c drivers/gpu/drm/xe/xe_pt_walk.c drivers/gpu/drm/xe/xe_pt_walk.h+46 -190 replies

Reviews trailers per patch

1 of 4 patches has a Reviewed-by or Acked-by.

PatchMatthew Brost
1/4R-b
2/4
3/4
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/4] drm/xe: Fix userptr races and missed validations

A series that fixes a couple of userptr races and a missed validation.

Patch 1
- Fixes a missed userptr validation causing a potential infinite loop. Patch 2
- Fixes a misplaced #endif in preparation for patch 3. Patch 3
- Fixes a race between fault mode invalidation and unbind, where the userptr invalidation could attempt to traverse a page-table tree under modification
Patch 4
- Fixes a race between fault mode invalidation and multiple bind operation, where the invalidation could potentially get lost.

v2:
- Fix an unintended Fallthrough (Matt Brost)
- Don't recommend backport of Patch2 for older kernels than 6.12+ (Lucas)
- Update the locking requirement docs and asserts for forced invalidations

Cc Matthew Brost <[email protected]>
Cc Matthew Auld <[email protected]>

Matthew Brost (1):
drm/xe: Add staging tree for VM binds

Thomas Hellström (3):
drm/xe/vm: Validate userptr during gpu vma prefetching drm/xe/vm: Fix a misplaced #endif
drm/xe: Fix fault mode invalidation with unbind

 drivers/gpu/drm/xe/xe_pt.c       | 96 ++++++++++++++++----------------
 drivers/gpu/drm/xe/xe_pt_walk.c  |  3 +-
 drivers/gpu/drm/xe/xe_pt_walk.h  |  4 ++
 drivers/gpu/drm/xe/xe_vm.c       | 96 ++++++++++++++++++++++----------
 drivers/gpu/drm/xe/xe_vm.h       | 10 +++-
 drivers/gpu/drm/xe/xe_vm_types.h |  4 +-
 6 files changed, 132 insertions(+), 81 deletions(-)
Signature · 1 line
2.48.1

Read the cover letter in its thread