Describe the cameras in the PinePhone Pro dts
Status from this message: Applied, thanks!
Get series with b4
b4 am [email protected] change-id 20250228-camera-7a894befafa7Versions newest first
- v4 Latest4 patches 8 repliesApplied
- v34 patches 6 repliesSuperseded
- v22 patches 1 replySuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 | 2 patches | 2 replies | Superseded |
Changes in v4 from the cover letter
- Dropped "clock-names" property from IM258 as it is absent from the binding.
- Renamed pinctrl definitions to match the names in the PinePhone Pro datasheet.
- Collected Rob Herring's acked-by for patches 1 and 2
- Link to v3: https://lore.kernel.org/r/[email protected]
Patches in v4 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | dt-bindings: media: ov8858: inherit video-interface-devices propertiesDocumentation/ | +3 | 0 replies | |
| 2/4 | dt-bindings: media: imx258: inherit video-interface-devices propertiesDocumentation/ | +3 | 0 replies | |
| 3/4 | arm64: dts: rockchip: describe I2c Bus 1 and IMX258 world camera on PinePhone Proarch/ | +93 | 2 replies | |
| 4/4 | arm64: dts: rockchip: describe the OV8858 user camera on PinePhone Proarch/ | +47 | 0 replies |
Reviews trailers per patch
2 of 4 patches have a Reviewed-by or Acked-by.
| Patch | Rob Herring (Arm) | Dragan Simic |
|---|---|---|
| 1/4 | A-b | |
| 2/4 | A-b | |
| 3/4 | Helped-by | |
| 4/4 | Helped-by |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v4 0/4] Describe the cameras in the PinePhone Pro dts
This series adds support for the Pine64 PinePhone Pro's rear and front cameras in Device Tree.
This is based on some of Ondrej Jirman's patches hosted in his tree at
https://codeberg.org/megi/linux, but I have also fully reviewed and re-written the code from the RK3399 datasheet, the PinePhone Pro schematic, and the IMX258-0AQH5 software reference manual.
I have tested these changes on my PinePhone Pro and am able to take photos from both cameras using libcamera's cam.
This series has raised a question about the proper label name for the front/user camera and rear/world camera for phones.
This series is using "ucam" and "wcam", which is used in a few other Rockship DTBs:
- arch/arm64/boot/dts/rockchip/px30-evb.dts
- rk3399-gru-scarlet.dtsi
---
Changes in v4:
- Dropped "clock-names" property from IM258 as it is absent from the binding.
- Renamed pinctrl definitions to match the names in the PinePhone Pro datasheet.
- Collected Rob Herring's acked-by for patches 1 and 2
- Link to v3: https://lore.kernel.org/r/[email protected]
Changes in v3:
- Fixed new DTB warnings reported by Rob Herring's bot
- Link to v2: https://lore.kernel.org/r/[email protected]
Changes in v2:
- Rebase on mainline
- Change patch subject to arm64: dts: rockchip
- Rename new regulators to fit preferred form for fixed regulators
- Link to v1: https://lore.kernel.org/r/[email protected]
---
Olivier Benjamin (4):
dt-bindings: media: ov8858: inherit video-interface-devices properties
dt-bindings: media: imx258: inherit video-interface-devices properties
arm64: dts: rockchip: describe I2c Bus 1 and IMX258 world camera on PinePhone Pro
arm64: dts: rockchip: describe the OV8858 user camera on PinePhone Pro
.../devicetree/bindings/media/i2c/ovti,ov8858.yaml | 4 +- .../devicetree/bindings/media/i2c/sony,imx258.yaml | 4 +- .../boot/dts/rockchip/rk3399-pinephone-pro.dts | 138 +++++++++++++++++++++ 3 files changed, 144 insertions(+), 2 deletions(-)
---
Signature · 1 line
Olivier Benjamin <[email protected]>