Skip to content

drm/xe: Userptr invalid page access fixes

Thomas Hellström intel-xe stable 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest3 patches 2 repliesIn review
  2. v23 patches 5 repliesSuperseded
  3. v13 patches 5 repliesSuperseded

v2 from the cover letter

- Address review comments by Matt Auld

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3drm/xe/hmm: Style- and include fixesdrivers/gpu/drm/xe/xe_hmm.c drivers/gpu/drm/xe/xe_hmm.h+8 -60 replies
2/3drm/xe/hmm: Don't dereference struct page pointers without notifier lockdrivers/gpu/drm/xe/xe_hmm.c+86 -260 replies
3/3drm/xe/userptr: Unmap userptrs in the mmu notifierdrivers/gpu/drm/xe/xe_hmm.c drivers/gpu/drm/xe/xe_hmm.h drivers/gpu/drm/xe/xe_vm.c +1 more+52 -90 replies

Reviews trailers per patch

2 of 3 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchMatthew AuldMatthew Brost
SeriesA-b
1/3
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/3] drm/xe: Userptr invalid page access fixes

Fix a number of potential invalid page-accesses by the userptr code.

Patch 1:
- Some coding style fixes.
Patch 2:
- Avoids invalid struct page accesses during userptr pinning. Patch 3:
- Block xe device accesses on mmu_invalidation on the iommu level.

v2:
- Address review comments by Matt Auld

Cc Matthew Auld <[email protected]>
Cc Oak Zeng <[email protected]>

Thomas Hellström (3):
drm/xe/hmm: Style- and include fixes
drm/xe/hmm: Don't dereference struct page pointers without notifier
lock
drm/xe/userptr: Unmap userptrs in the mmu notifier

 drivers/gpu/drm/xe/xe_hmm.c      | 170 +++++++++++++++++++++++--------
 drivers/gpu/drm/xe/xe_hmm.h      |   7 ++
 drivers/gpu/drm/xe/xe_vm.c       |   4 +
 drivers/gpu/drm/xe/xe_vm_types.h |   4 +
 4 files changed, 145 insertions(+), 40 deletions(-)
Signature · 1 line
2.48.1