tests/xe_drm_fdinfo: Check prerequisites for utilization tests
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest2 patches 4 repliesIn review
- v12 patches 7 repliesSuperseded
Changes in v2 from the cover letter
- Dropped igt_subtest_group, as its fixture executed unconditionally.
- Introduced require_engine_utilization_data() helper to check prerequisites in each subtest.
- Extended the requirement checks for the presence of engine utilization cycles.
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | tests/intel/xe_drm_fdinfo: Check prerequisites for utilization subteststests/ | +43 | 2 replies | |
| 2/2 | tests/intel/xe_drm_fdinfo: Fail basic_engine_utilization if no utilization datatests/ | +1 | 1 reply |
Reviews trailers per patch
All 2 patches have a Reviewed-by or Acked-by.
| Patch | Jakub Kolakowski | Kamil Konieczny |
|---|---|---|
| 1/2 | R-b | R-b |
| 2/2 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v2 i-g-t 0/2] tests/xe_drm_fdinfo: Check prerequisites for utilization tests
This patch series ensures that utilization tests correctly check for required utilization data before execution.
The first patch initially introduced an igt_subtest_group with a fixture to verify utilization data availability. However, as pointed out by Kamil, the fixture would still execute even if no test from the group was selected, leading to potential log messages about unmet requirements when running unrelated tests.
To address this, v2 introduces a helper function, require_engine_utilization_data(), which is explicitly called in each utilization-related subtest.
The second patch remains unchanged and replaces igt_require with igt_assert in basic_engine_utilization, ensuring the test fails explicitly when utilization data is missing.
V2:
- Dropped igt_subtest_group, as its fixture executed unconditionally.
- Introduced require_engine_utilization_data() helper to check prerequisites in each subtest.
- Extended the requirement checks for the presence of engine utilization cycles.
Marcin Bernatowicz (2):
tests/intel/xe_drm_fdinfo: Check prerequisites for utilization
subtests
tests/intel/xe_drm_fdinfo: Fail basic_engine_utilization if no
utilization data
tests/intel/xe_drm_fdinfo.c | 56 +++++++++++++++++++++++++++++-------- 1 file changed, 44 insertions(+), 12 deletions(-)
Signature · 1 line
2.31.1