Skip to content

NVMe PCI endpoint target fixes

Damien Le Moal linux-nvme 3 versions – Applied

Status from this message: applied to nvme-6.15.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest posting 2/23 patches 2 repliesApplied
  2. v2 posting 1/22 patches 3 repliesApplied
  3. v12 patches 0 repliesSuperseded

Changes in v2 from the cover letter

- Patch 1: Add comments explaining iwhy the cqe needs to be initialized and also add setting the cqe sq_head field.
- Fixed typos in patch 2 commit message
- Added review tags to patch 3

Patches in v2 posting 2/2 Applied

#Subject and filesSizeRepliesApplied
1/3nvmet: pci-epf: Always fully initialize completion entriesdrivers/nvme/target/pci-epf.c+18 -71 reply
2/3nvmet: pci-epf: Clear CC and CSTS when disabling the controllerdrivers/nvme/target/pci-epf.c+32 -170 replies
3/3nvmet: pci-epf: Cleanup link state managementdrivers/nvme/target/pci-epf.c+8 -60 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchNiklas CasselKeith Busch
1/3R-b
2/3R-b
3/3R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/3] NVMe PCI endpoint target fixes

Two bug fix patch and one cleanup patch in this series.

The first patch fixes an issue with completion queue entries initialization in the case of failed commands.

The second patch fixes
the initialization of the CC register to ensure that we can always detect that the host is attempting to enable the controller (with CC.EN).

The last patch cleans up/simplifies the management of the PCI link state.

Changes from v1:
- Patch 1: Add comments explaining iwhy the cqe needs to be initialized and also add setting the cqe sq_head field.
- Fixed typos in patch 2 commit message
- Added review tags to patch 3

Damien Le Moal (3):
nvmet: pci-epf: Always fully initialize completion entries
nvmet: pci-epf: Clear CC and CSTS when disabling the controller
nvmet: pci-epf: Cleanup link state management

 drivers/nvme/target/pci-epf.c | 88 +++++++++++++++++++++++------------
 1 file changed, 58 insertions(+), 30 deletions(-)
Signature · 1 line
2.49.0