Skip to content

Support AST2700 A1

Jamin Lin via qemu-arm qemu-devel 2 versions – Applied

Status from this message: Applied to aspeed-next.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest14 of 29 patches 8 repliesApplied
  2. v515 of 29 patches 11 repliesSuperseded

Changes in v6 from the cover letter

1. rename reg_size to nr_regs
2. Fix clean regs size
3. replace g_malloc with g_new

14 of 29 patches are in this archive. The cover letter announces 29.

Patches in v6 Applied

#Subject and filesSizeRepliesApplied
2/29hw/intc/aspeed: Rename status_addr and addr to status_reg and reg for clarityhw/intc/aspeed_intc.c+19 -190 replies
4/29hw/intc/aspeed: Support setting different register sizehw/intc/aspeed_intc.c include/hw/intc/aspeed_intc.h+6 -181 reply
5/29hw/intc/aspeed: Reduce regs array size by adding a register sub-regionhw/intc/aspeed_intc.c include/hw/intc/aspeed_intc.h+30 -211 reply
6/29hw/intc/aspeed: Introduce helper functions for enable and status registershw/intc/aspeed_intc.c+108 -830 replies
8/29hw/arm/aspeed: Rename IRQ table and machine name for AST2700 A0hw/arm/aspeed.c hw/arm/aspeed_ast27x0.c+9 -80 replies
9/29hw/arm/aspeed_ast27x0: Sort the IRQ table by IRQ numberhw/arm/aspeed_ast27x0.c+25 -250 replies
10/29hw/intc/aspeed: Support different memory region opshw/intc/aspeed_intc.c include/hw/intc/aspeed_intc.h+5 -10 replies
11/29hw/intc/aspeed: Rename num_ints to num_inpins for clarityhw/arm/aspeed_ast27x0.c hw/intc/aspeed_intc.c include/hw/intc/aspeed_intc.h+24 -200 replies
15/29hw/intc/aspeed: Introduce IRQ handler function to reduce code duplicationhw/intc/aspeed_intc.c+39 -310 replies
16/29hw/intc/aspeed: Add Support for Multi-Output IRQ Handlinghw/intc/aspeed_intc.c hw/intc/trace-events include/hw/intc/aspeed_intc.h+137 -170 replies
18/29hw/misc/aspeed_scu: Add Support for AST2700/AST2750 A1 Silicon Revisionshw/misc/aspeed_scu.c include/hw/misc/aspeed_scu.h+4 -00 replies
23/29hw/arm/aspeed: Add Machine Support for AST2700 A1hw/arm/aspeed.c+24 -00 replies
25/29tests/functional/aspeed: Introduce start_ast2700_test APItests/functional/test_aarch64_aspeed.py+15 -140 replies
27/29tests/functional/aspeed: Update test ASPEED SDK v09.05tests/functional/test_aarch64_aspeed.py+6 -60 replies

Reviews trailers per patch

All 14 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchCédric Le Goater
SeriesR-b R-b R-b R-b R-b R-b R-b R-b R-b R-b R-b R-b R-b R-b R-b
2/29R-b
4/29R-b
5/29R-b
6/29R-b
8/29R-b
9/29R-b
10/29R-b
11/29R-b
15/29R-b
16/29R-b
18/29R-b
23/29R-b
25/29R-b
27/29R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v6 thread

Cover letter [PATCH v6 00/29] Support AST2700 A1

v1:
1. Refactor INTC model to support both INTC0 and INTC1.
2. Support AST2700 A1.
3. Create ast2700a0-evb machine.

v2:
To streamline the review process, split the following patch series into three parts.
https://patchwork.kernel.org/project/qemu-devel/cover/[email protected]/
This patch series focuses on cleaning up the INTC model to facilitate future support for the INTC_IO model.

v3:
1. Update and add functional test for AST2700
2. Add AST2700 INTC design guidance and its block diagram.
3. Retaining the INTC naming and introducing a new INTCIO model to support the AST2700 A1.
4. Create ast2700a1-evb machine and rename ast2700a0-evb machine
5. Fix silicon revision issue and support AST2700 A1.

v4:
1. rework functional test for AST2700
2. the initial machine "ast2700-evb" is aliased to "ast2700a0-evb.
3. intc: Reduce regs array size by adding a register sub-region
4. intc: split patch for Support setting different register sizes
5. update ast2700a1-evb machine parent to TYPE_ASPEED_MACHINE

v5:
1. Rename status_addr and addr to status_reg and reg for clarity
2. Introduce dynamic allocation for regs array
3. Sort the memmap table by mapping address
4. ast27x0.c split patch for Support two levels of INTC controllers for AST2700 A1
5. tests/functional/aspped split patch for Introduce start_ast2700_test API
6. keep variable naming for reviewer suggestion.
7. Add reviewer suggestion and split patch to make more readable.

v6:
1. rename reg_size to nr_regs
2. Fix clean regs size
3. replace g_malloc with g_new

With the patch applied, QEMU now supports two machines for running AST2700 SoCs:
ast2700a0-evb: Designed for AST2700 A0
ast2700a1-evb: Designed for AST2700 A1

Test information
1. QEMU version: https://github.com/qemu/qemu/commit/50d38b8921837827ea397d4b20c8bc5efe186e53
2. ASPEED SDK v09.05 pre-built image
https://github.com/AspeedTech-BMC/openbmc/releases/tag/v09.05
ast2700-default-obmc.tar.gz (AST2700 A1)
https://github.com/AspeedTech-BMC/openbmc/releases/download/v09.05/ast2700-default-obmc.tar.gz
ast2700-a0-default-obmc.tar.gz (AST2700 A0)
https://github.com/AspeedTech-BMC/openbmc/releases/download/v09.05/ast2700-a0-default-obmc.tar.gz

This patch series depends on the following patch series:
https://patchwork.kernel.org/project/qemu-devel/cover/[email protected]/
https://patchwork.kernel.org/project/qemu-devel/cover/[email protected]/

Jamin Lin (29):
hw/intc/aspeed: Support setting different memory size hw/intc/aspeed: Rename status_addr and addr to status_reg and reg for
clarity
hw/intc/aspeed: Introduce dynamic allocation for regs array hw/intc/aspeed: Support setting different register size hw/intc/aspeed: Reduce regs array size by adding a register sub-region hw/intc/aspeed: Introduce helper functions for enable and status
registers
hw/intc/aspeed: Add object type name to trace events for better
debugging
hw/arm/aspeed: Rename IRQ table and machine name for AST2700 A0 hw/arm/aspeed_ast27x0: Sort the IRQ table by IRQ number hw/intc/aspeed: Support different memory region ops hw/intc/aspeed: Rename num_ints to num_inpins for clarity hw/intc/aspeed: Add support for multiple output pins in INTC hw/intc/aspeed: Refactor INTC to support separate input and output pin
indices
hw/intc/aspeed: Introduce AspeedINTCIRQ structure to save the irq
index and register address
hw/intc/aspeed: Introduce IRQ handler function to reduce code
duplication
hw/intc/aspeed: Add Support for Multi-Output IRQ Handling hw/intc/aspeed: Add Support for AST2700 INTCIO Controller hw/misc/aspeed_scu: Add Support for AST2700/AST2750 A1 Silicon
Revisions
hw/arm/aspeed_ast27x0.c Support AST2700 A1 GIC Interrupt Mapping hw/arm/aspeed_ast27x0: Define an Array of AspeedINTCState with Two
Instances
hw/arm/aspeed_ast27x0: Support two levels of INTC controllers for

    AST2700 A1

hw/arm/aspeed_ast27x0: Add SoC Support for AST2700 A1 hw/arm/aspeed: Add Machine Support for AST2700 A1 hw/arm/aspeed_ast27x0: Sort the memmap table by mapping address tests/functional/aspeed: Introduce start_ast2700_test API tests/functional/aspeed: Update temperature hwmon path tests/functional/aspeed: Update test ASPEED SDK v09.05 tests/functional/aspeed: Add test case for AST2700 A1 docs/specs: Add aspeed-intc

 docs/specs/aspeed-intc.rst              | 136 +++++
 docs/specs/index.rst                    |   1 +
 include/hw/arm/aspeed_soc.h             |   3 +-
 include/hw/intc/aspeed_intc.h           |  36 +-
 include/hw/misc/aspeed_scu.h            |   2 +
 hw/arm/aspeed.c                         |  33 +-
 hw/arm/aspeed_ast27x0.c                 | 329 ++++++++----
 hw/intc/aspeed_intc.c                   | 667 ++++++++++++++++++------
 hw/misc/aspeed_scu.c                    |   2 +
 hw/intc/trace-events                    |  25 +-
 tests/functional/test_aarch64_aspeed.py |  47 +-
 11 files changed, 978 insertions(+), 303 deletions(-)
 create mode 100644 docs/specs/aspeed-intc.rst
Signature · 1 line
2.43.0