Skip to content

RFC Underrun on idle PSR workaround

Jouni Högander intel-gfx intel-xe 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest11 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11drm/i915/display: Add new interface for getting dc_statedrivers/gpu/drm/i915/display/intel_display_power.c drivers/gpu/drm/i915/display/intel_display_power.h+30 -01 reply
2/11drm/i915/psr: Store enabled non-psr pipes into intel_crtc_statedrivers/gpu/drm/i915/display/intel_display_types.h drivers/gpu/drm/i915/display/intel_psr.c+26 -01 reply
3/11drm/i915/dmc: Add PIPEDMC_EVT_CTL register definitiondrivers/gpu/drm/i915/display/intel_dmc_regs.h+6 -01 reply
4/11drm/i915/dmc: Add PIPEDMC_BLOCK_PKGC_SW definitionsdrivers/gpu/drm/i915/display/intel_dmc_regs.h+8 -00 replies
5/11drm/i915/psr: Write PIPEDMC_BLOCK_PKGC_SW when enabling PSRdrivers/gpu/drm/i915/display/intel_psr.c+15 -00 replies
6/11drm/i915/psr: Add mechanism to notify PSR of pipe enable/disabledrivers/gpu/drm/i915/display/intel_psr.c drivers/gpu/drm/i915/display/intel_psr.h+108 -00 replies
7/11drm/i915/psr: Add mechanism to notify PSR of DC5/6 enable disabledrivers/gpu/drm/i915/display/intel_display_core.h drivers/gpu/drm/i915/display/intel_psr.c drivers/gpu/drm/i915/display/intel_psr.h+54 -00 replies
8/11drm/i915/psr: Add interface to notify PSR of vblank enable/disabledrivers/gpu/drm/i915/display/intel_psr.c drivers/gpu/drm/i915/display/intel_psr.h+42 -00 replies
9/11drm/i915/psr: Apply underrun on PSR idle workarounddrivers/gpu/drm/i915/display/intel_display.c drivers/gpu/drm/i915/display/intel_display_driver.c drivers/gpu/drm/i915/display/intel_display_irq.c +2 more+74 -470 replies
10/11drm/i915/display: Rename intel_psr_needs_block_dc_vblankdrivers/gpu/drm/i915/display/intel_crtc.c drivers/gpu/drm/i915/display/intel_display_irq.c drivers/gpu/drm/i915/display/intel_display_types.h +2 more+11 -90 replies
11/11drm/i915/display: Rename vblank DC workaround functions and variablesdrivers/gpu/drm/i915/display/intel_crtc.c drivers/gpu/drm/i915/display/intel_display_core.h drivers/gpu/drm/i915/display/intel_display_irq.c+13 -130 replies

Reviews trailers per patch

3 of 11 patches have a Reviewed-by or Acked-by.

PatchMika Kahola
1/11R-b
2/11R-b
3/11R-b
4/11
5/11
6/11
7/11
8/11
9/11
10/11
11/11

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [RFC PATCH 00/11] Underrun on idle PSR workaround

This patchset is implementing workaround for underrun on idle PSR HW bug.

It is adding notification mechanisms toward PSR for pipe enable/disable, vblank enable/disable and enabling disabling DC5/DC6. These notifications are used to apply/remove the workaround.

Current mechanism to block DC states while vblank is enabled on Panel Replay capable system is extended to work for this new workaround as well.

Jouni Högander (11):
drm/i915/display: Add new interface for getting dc_state drm/i915/psr: Store enabled non-psr pipes into intel_crtc_state drm/i915/dmc: Add PIPEDMC_EVT_CTL register definition drm/i915/dmc: Add PIPEDMC_BLOCK_PKGC_SW definitions drm/i915/psr: Write PIPEDMC_BLOCK_PKGC_SW when enabling PSR drm/i915/psr: Add mechanism to notify PSR of pipe enable/disable drm/i915/psr: Add mechanism to notify PSR of DC5/6 enable disable drm/i915/psr: Add interface to notify PSR of vblank enable/disable drm/i915/psr: Apply underrun on PSR idle workaround drm/i915/display: Rename intel_psr_needs_block_dc_vblank drm/i915/display: Rename vblank DC workaround functions and variables

 drivers/gpu/drm/i915/display/intel_crtc.c     |   6 +-
 drivers/gpu/drm/i915/display/intel_display.c  |   4 +
 .../gpu/drm/i915/display/intel_display_core.h |   6 +-
 .../drm/i915/display/intel_display_driver.c   |   3 +
 .../gpu/drm/i915/display/intel_display_irq.c  |  27 +-
 .../drm/i915/display/intel_display_power.c    |  29 ++
 .../drm/i915/display/intel_display_power.h    |   1 +
 .../i915/display/intel_display_power_well.c   |   4 +
 .../drm/i915/display/intel_display_types.h    |   5 +-
 drivers/gpu/drm/i915/display/intel_dmc_regs.h |  14 +
 drivers/gpu/drm/i915/display/intel_psr.c      | 271 +++++++++++++++++-
 drivers/gpu/drm/i915/display/intel_psr.h      |   8 +-
 12 files changed, 348 insertions(+), 30 deletions(-)
Signature · 1 line
2.43.0