Skip to content

nvme-tcp: fixup I/O stall on congested sockets

Hannes Reinecke linux-nvme 6 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 posting 2/23 patches 5 repliesIn review
  2. v5 Latest2 patches 3 repliesIn review
  3. v4 posting 1/22 patches 2 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v33 patches40 repliesSuperseded
v25 patches0 repliesSuperseded
v13 patches7 repliesSuperseded

Changes to v4 from the cover letter

- Drop check for 'queue->req' as noticed by Sagi

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2nvme-tcp: sanitize request list handlingdrivers/nvme/host/tcp.c+14 -11 reply
2/2nvme-tcp: fix I/O stalls on congested socketsdrivers/nvme/host/tcp.c+6 -12 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchChris LeechSagi Grimberg
1/2R-b
2/2A-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCHv5 0/2] nvme-tcp: fixup I/O stall on congested sockets

Hi all,

I have been chasing keep-alive timeouts with TLS enabled in the last few weeks (monthsA, even ...). On larger setups (eg with 32 queues) the connection never got established properly as I've been hitting keep-alive timeouts before the last queue got connected.
Turns out that occasionally we simply do not send the keep-alive request; it's been added to the request list but the io_work workqueue function is never restarted as it bails out after nvme_tcp_try_recv() returns -EAGAIN. During debugging I also found that we're quite lazy with the list handling of requests, so I've added a patche to ensure that all list elements are properly terminated.

As usual, comments and reviews are welcome.

Changes to v4:
- Drop check for 'queue->req' as noticed by Sagi

Changes to v3:
- Drop first patch as it already had been applied
- Include reviews from Sagi
- Check for sk_sock_is_writeable() to avoid requeing io_work when the socket is blocked

Changes to v2:
- Removed AEN patches again

Changes to the original submission:
- Include reviews from Chris Leech
- Add patch to requeue namespace scan
- Add patch to re-read ANA log page

Hannes Reinecke (2):
nvme-tcp: sanitize request list handling
nvme-tcp: fix I/O stalls on congested sockets

 drivers/nvme/host/tcp.c | 22 ++++++++++++++++++++--
 1 file changed, 20 insertions(+), 2 deletions(-)
Signature · 1 line
2.35.3