Skip to content

drm/i915: sagv/bw cleanup

Ville Syrjala intel-gfx intel-xe 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest14 patches 7 repliesIn review
  2. v114 patches 0 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/14drm/i915: Drop the cached per-pipe min_cdclk[] from bw statedrivers/gpu/drm/i915/display/intel_bw.c drivers/gpu/drm/i915/display/intel_bw.h+8 -101 reply
2/14drm/i915: s/intel_crtc_bw/intel_dbuf_bw/drivers/gpu/drm/i915/display/intel_bw.c+12 -121 reply
3/14drm/i915: Extract intel_dbuf_bw_changed()drivers/gpu/drm/i915/display/intel_bw.c+17 -61 reply
4/14drm/i915: Pass intel_dbuf_bw to skl_*_calc_dbuf_bw() explicitlydrivers/gpu/drm/i915/display/intel_bw.c+6 -71 reply
5/14drm/i915: Avoid triggering unwanted cdclk changes due to dbuf bandwidth changesdrivers/gpu/drm/i915/display/intel_bw.c+13 -42 replies
6/14drm/i915: Do more bw readoutdrivers/gpu/drm/i915/display/intel_bw.c drivers/gpu/drm/i915/display/intel_cdclk.c+7 -00 replies
7/14drm/i915: Flag even inactive crtcs as "inherited"drivers/gpu/drm/i915/display/intel_display.c drivers/gpu/drm/i915/display/intel_modeset_setup.c+14 -110 replies
8/14drm/i915: Drop force_check_qgvdrivers/gpu/drm/i915/display/intel_bw.c drivers/gpu/drm/i915/display/intel_bw.h+6 -120 replies
9/14drm/i915: Extract intel_bw_modeset_checks()drivers/gpu/drm/i915/display/intel_bw.c drivers/gpu/drm/i915/display/intel_bw.h drivers/gpu/drm/i915/display/intel_display.c +1 more+36 -90 replies
10/14drm/i915: Extract intel_bw_check_sagv_mask()drivers/gpu/drm/i915/display/intel_bw.c drivers/gpu/drm/i915/display/intel_bw.h drivers/gpu/drm/i915/display/skl_watermark.c +1 more+46 -270 replies
11/14drm/i915: Make intel_bw_check_sagv_mask() internal to intel_bw.cdrivers/gpu/drm/i915/display/intel_bw.c drivers/gpu/drm/i915/display/intel_bw.h drivers/gpu/drm/i915/display/skl_watermark.c+8 -70 replies
12/14drm/i915: Make intel_bw_modeset_checks() internal to intel_bw_atomic_check()drivers/gpu/drm/i915/display/intel_bw.c drivers/gpu/drm/i915/display/intel_bw.h drivers/gpu/drm/i915/display/intel_display.c+10 -110 replies
13/14drm/i915: Skip bw stuff if per-crtc sagv state doesn't changedrivers/gpu/drm/i915/display/intel_bw.c drivers/gpu/drm/i915/display/skl_watermark.c+16 -30 replies
14/14drm/i915: Eliminate intel_compute_sagv_mask()drivers/gpu/drm/i915/display/skl_watermark.c+24 -400 replies

Reviews trailers per patch

5 of 14 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchJani Nikula
SeriesR-b
1/14R-b
2/14R-b
3/14R-b
4/14R-b
5/14R-b
6/14
7/14
8/14
9/14
10/14
11/14
12/14
13/14
14/14

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 00/14] drm/i915: sagv/bw cleanup

From: Ville Syrjälä <[email protected]>

Continue improving the code around sagv/bw vs. watermarks. A lot of the details get better encapsulated within intel_bw.c and the complicated interactions between different parts of the code are somewhat reduced.

v2: Rebase due to intel_display conversions

Ville Syrjälä (14):
drm/i915: Drop the cached per-pipe min_cdclk[] from bw state drm/i915: s/intel_crtc_bw/intel_dbuf_bw/
drm/i915: Extract intel_dbuf_bw_changed()
drm/i915: Pass intel_dbuf_bw to skl_*_calc_dbuf_bw() explicitly drm/i915: Avoid triggering unwanted cdclk changes due to dbuf
bandwidth changes
drm/i915: Do more bw readout
drm/i915: Flag even inactive crtcs as "inherited" drm/i915: Drop force_check_qgv
drm/i915: Extract intel_bw_modeset_checks()
drm/i915: Extract intel_bw_check_sagv_mask() drm/i915: Make intel_bw_check_sagv_mask() internal to intel_bw.c drm/i915: Make intel_bw_modeset_checks() internal to
intel_bw_atomic_check()
drm/i915: Skip bw stuff if per-crtc sagv state doesn't change drm/i915: Eliminate intel_compute_sagv_mask()

 drivers/gpu/drm/i915/display/intel_bw.c       | 187 ++++++++++++++----
 drivers/gpu/drm/i915/display/intel_bw.h       |   9 +-
 drivers/gpu/drm/i915/display/intel_cdclk.c    |   4 +
 drivers/gpu/drm/i915/display/intel_display.c  |   5 +-
 .../drm/i915/display/intel_modeset_setup.c    |  22 +--
 drivers/gpu/drm/i915/display/skl_watermark.c  | 112 ++++-------
 drivers/gpu/drm/i915/display/skl_watermark.h  |   1 +
 7 files changed, 202 insertions(+), 138 deletions(-)
Signature · 1 line
2.45.3