Skip to content

bpftool: Using the right format specifiers

Jiayuan Chen bpf lkml 2 versions – Applied

Status from this message: This series was applied to bpf/bpf-next.git (master)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 0 repliesApplied 2/2
  2. v12 patches 3 repliesSuperseded

Changes in v2 from the cover letter

https://lore.kernel.org/bpf/[email protected]/
---
Jiayuan Chen (2):
bpftool: Add -Wformat-signedness flag to detect format errors
bpftool: Using the right format specifiers

Patches in v2 All 2 applied

#Subject and filesSizeRepliesApplied
1/2bpftool: Add -Wformat-signedness flag to detect format errorstools/bpf/bpftool/Makefile+6 -10 repliesApplied
2/2bpftool: Using the right format specifierskernel/bpf/disasm.c tools/bpf/bpftool/btf.c tools/bpf/bpftool/btf_dumper.c +9 more+33 -320 repliesApplied

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH bpf-next v2 0/2] bpftool: Using the right format specifiers

This patch adds the -Wformat-signedness compiler flag to detect and prevent format string errors, where signed or unsigned types are mismatched with format specifiers. Additionally, it fixes some format string errors that were not fully addressed by the previous patch [1].

[1] https://lore.kernel.org/bpf/[email protected]/T/#u

---
v1->v2:
https://lore.kernel.org/bpf/[email protected]/
---
Jiayuan Chen (2):
bpftool: Add -Wformat-signedness flag to detect format errors
bpftool: Using the right format specifiers

 kernel/bpf/disasm.c                |  4 ++--
 tools/bpf/bpftool/Makefile         |  7 ++++++-
 tools/bpf/bpftool/btf.c            | 14 +++++++-------
 tools/bpf/bpftool/btf_dumper.c     |  2 +-
 tools/bpf/bpftool/cgroup.c         |  2 +-
 tools/bpf/bpftool/common.c         |  4 ++--
 tools/bpf/bpftool/jit_disasm.c     |  3 ++-
 tools/bpf/bpftool/map_perf_ring.c  |  6 +++---
 tools/bpf/bpftool/net.c            |  4 ++--
 tools/bpf/bpftool/netlink_dumper.c |  6 +++---
 tools/bpf/bpftool/prog.c           | 12 ++++++------
 tools/bpf/bpftool/tracelog.c       |  2 +-
 tools/bpf/bpftool/xlated_dumper.c  |  6 +++---
 13 files changed, 39 insertions(+), 33 deletions(-)
Signature · 1 line
2.47.1