Consistently prioritize legacy events
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest2 patches 0 repliesNew
- v12 patches 0 repliesSuperseded
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | perf parse-events: Make legacy events always have priority over sysfs/jsontools/ tools/ | +12 | 0 replies | |
| 2/2 | Revert "perf evsel: Add alternate_hw_config and use in evsel__match"tools/ tools/ tools/ +6 more | +45 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.
Cover letter [PATCH v2 0/2] Consistently prioritize legacy events
Legacy events were historically the priority over sysfs/json events. This behavior was changed in commit a24d9d9dc096 ("perf
parse-events: Make legacy events lower priority than sysfs/JSON") to fix issues on ARM Apple-M CPUs. Sysfs/json being the priority makes most sense, was preferred by RISC-V and gives abilities impossible with legacy events. Making this encoding consistent is proving impossible with endless bike shedding, people saying they see something as a fix then when that fix is provided continuing to object, etc. Given that in the RFC [1] legacy events are seen as being preferrable let's just follow up on that and make their use consistent.
If it isn't clear, I think this is the wrong decision and landing [2] should be the priority. When I try to have this conversation it just gets ignored and I want consistency more than my preferred prioritization.
[1] https://lore.kernel.org/lkml/[email protected]/
[2] https://lore.kernel.org/linux-perf-users/[email protected]/
v2: Missed revert of stat-display logic for json event prioritization.
Ian Rogers (2):
perf parse-events: Make legacy events always have priority over
sysfs/json
Revert "perf evsel: Add alternate_hw_config and use in evsel__match"
tools/perf/builtin-diff.c | 6 +-- tools/perf/tests/parse-events.c | 13 ++---- tools/perf/util/evsel.c | 21 --------- tools/perf/util/evsel.h | 19 +++++++- tools/perf/util/parse-events.c | 81 ++++++++++++--------------------- tools/perf/util/parse-events.h | 8 +--- tools/perf/util/parse-events.y | 2 +- tools/perf/util/pmu.c | 6 +-- tools/perf/util/pmu.h | 2 +- tools/perf/util/stat-display.c | 6 --- 10 files changed, 57 insertions(+), 107 deletions(-)
Signature · 1 line
2.49.0.rc0.332.g42c0ae87b1-goog