target/hexagon: Fix macOS build
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest2 patches 3 repliesIn review
- v12 patches 4 repliesSuperseded
Changes in v2 from the cover letter
* Don't remove the indent step but only run on linux hosts.
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | target/hexagon: Replace `prepare` script with meson targettarget/ target/ | +2 | 1 reply | |
| 2/2 | target/hexagon: Only indent on linuxtarget/ | +1 | 1 reply |
Reviews trailers per patch
All 2 patches have a Reviewed-by or Acked-by.
| Patch | Brian Cain |
|---|---|
| 1/2 | R-b |
| 2/2 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v2 0/2] target/hexagon: Fix macOS build
A default macOS build with xcode cli tools installed lacks the indent program needed by the idef-parser postprocess step. If indent is installed through homebrew it doesn't support the -linux flag. Conditionally run indent only on linux hosts.
Additionally cpp used by the idef-parser preprocess step expands into clang ... -traditional-cpp and doesn't support macro concatenation among other things, replace it with a meson custom_target running ${compiler} -E.
Note: default bison on macOS is still too old (v2.3 vs v3.0) and a newer version needs to be installed via homebrew. I'll take a look at supporting v2.3.
Changes in v2:
* Don't remove the indent step but only run on linux hosts.
Anton Johansson (2):
target/hexagon: Replace prepare script with meson target target/hexagon: Only indent on linux
target/hexagon/idef-parser/prepare | 24 ------------------------ target/hexagon/meson.build | 5 +++-- 2 files changed, 3 insertions(+), 26 deletions(-) delete mode 100755 target/hexagon/idef-parser/prepare
Signature · 1 line
2.47.1