Improve soundness of bus device abstractions
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest4 patches 9 repliesIn review
- v14 patches 14 repliesSuperseded
Changes in v2 from the cover letter
- make DeviceContext trait sealed
- impl From<&pci::Device<device::Core>> for ARef<pci::Device>
- impl From<&platform::Device<device::Core>> for ARef<platform::Device>
- rebase onto v6.14-rc6
- apply RBs
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | rust: pci: use to_result() in enable_device_mem()rust/ | +1 | 0 replies | |
| 2/4 | rust: device: implement device context markerrust/ | +26 | 4 replies | |
| 3/4 | rust: pci: fix unrestricted &mut pci::Devicerust/ samples/ | +89 | 0 replies | |
| 4/4 | rust: platform: fix unrestricted &mut platform::Devicerust/ samples/ | +72 | 0 replies |
Reviews trailers per patch
All 4 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Benno Lossin | Boqun Feng |
|---|---|---|
| Series | A-b | |
| 1/4 | R-b | |
| 2/4 | R-b | |
| 3/4 | R-b | |
| 4/4 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v2 0/4] Improve soundness of bus device abstractions
Currently, when sharing references of bus devices (e.g. ARef<pci::Device>), we do not have a way to restrict which functions of a bus device can be called.
Consequently, it is possible to call all bus device functions concurrently from any context. This includes functions, which access fields of the (bus) device, which are not protected against concurrent access.
This is improved by applying an execution context to the bus device in form of a generic type.
For instance, the PCI device reference that is passed to probe() has the type pci::Device<Core>, which implements all functions that are only allowed to be called from bus callbacks.
The implementation for the default context (pci::Device) contains all functions that are safe to call from any context concurrently.
The context types can be extended as required, e.g. to limit availability of certain (bus) device functions to probe().
A branch containing the patches can be found in [1].
[1] https://web.git.kernel.org/pub/scm/linux/kernel/git/dakr/linux.git/log/?h=rust/device
Changes in v2:
- make DeviceContext trait sealed
- impl From<&pci::Device<device::Core>> for ARef<pci::Device>
- impl From<&platform::Device<device::Core>> for ARef<platform::Device>
- rebase onto v6.14-rc6
- apply RBs
Danilo Krummrich (4):
rust: pci: use to_result() in enable_device_mem()
rust: device: implement device context marker
rust: pci: fix unrestricted &mut pci::Device
rust: platform: fix unrestricted &mut platform::Device
rust/kernel/device.rs | 26 +++++ rust/kernel/pci.rs | 137 +++++++++++++++++---------- rust/kernel/platform.rs | 95 +++++++++++++------ samples/rust/rust_driver_pci.rs | 8 +- samples/rust/rust_driver_platform.rs | 11 ++- 5 files changed, 187 insertions(+), 90 deletions(-)
base-commit: 80e54e84911a923c40d7bee33a34c1b4be148d7a
Signature · 1 line
2.48.1