genirq: Cleanups and conversion to lock guards
Status from this message: The following commit has been merged into the irq/core branch of tip:
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest45 patches 25 repliesApplied
- v146 patches 3 repliesSuperseded
Changes in v2 from the cover letter
- Rebase on latest tip irq/core
- Make coding style consistent (Jiri, Shrikanth)
Patches in v2 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/45 | genirq: Provide conditional lock guardskernel/ | +29 | 0 replies | |
| 2/45 | genirq/irqdesc: Switch to lock guardskernel/ | +43 | 1 reply | |
| 2/45 | genirq/irqdesc: Switch to lock guardskernel/ | +44 | 1 reply | |
| 3/45 | genirq/autoprobe: Switch to lock guardskernel/ | +9 | 0 replies | |
| 4/45 | genirq/pm: Switch to lock guardskernel/ | +13 | 0 replies | |
| 5/45 | genirq/resend: Switch to lock guardskernel/ | +21 | 0 replies | |
| 6/45 | genirq/proc: Switch to lock guardskernel/ | +24 | 5 replies | |
| 7/45 | genirq/spurious: Cleanup codekernel/ | +28 | 0 replies | |
| 8/45 | genirq/spurious: Switch to lock guardskernel/ | +12 | 0 replies | |
| 9/45 | genirq/cpuhotplug: Convert to lock guardskernel/ | +4 | 2 replies | |
| 10/45 | genirq/debugfs: Convert to lock guardskernel/ | +1 | 0 replies | |
| 11/45 | genirq/chip: Prepare for code reductionkernel/ | +27 | 0 replies | |
| 12/45 | genirq/chip: Rework handle_nested_irq()kernel/ | +36 | 2 replies | |
| 13/45 | genirq/chip: Rework handle_simple_irq()kernel/ | +10 | 0 replies | |
| 14/45 | genirq/chip: Rework handle_untracked_irq()kernel/ | +16 | 0 replies | |
| 15/45 | genirq/chip: Rework handle_level_irq()kernel/ | +9 | 0 replies | |
| 16/45 | genirq/chip: Rework handle_eoi_irq()kernel/ | +18 | 0 replies | |
| 17/45 | genirq/chip: Rework handle_edge_irq()kernel/ | +16 | 0 replies | |
| 18/45 | genirq/chip: Rework handle_fasteoi_ack_irq()kernel/ | +13 | 0 replies | |
| 19/45 | genirq/chip: Rework handle_fasteoi_mask_irq()kernel/ | +9 | 0 replies | |
| 20/45 | genirq/chip: Use lock guards where applicablekernel/ | +8 | 0 replies | |
| 21/45 | genirq/chip: Rework irq_set_chip()kernel/ | +12 | 0 replies | |
| 22/45 | genirq/chip: Rework irq_set_irq_type()kernel/ | +6 | 0 replies | |
| 23/45 | genirq/chip: Rework irq_set_handler_data()kernel/ | +9 | 0 replies | |
| 24/45 | genirq/chip: Rework irq_set_msi_desc_off()kernel/ | +17 | 0 replies | |
| 25/45 | genirq/chip: Rework irq_set_chip_data()kernel/ | +9 | 0 replies | |
| 26/45 | genirq/chip: Rework irq_set_handler() variantskernel/ | +11 | 7 replies | |
| 27/45 | genirq/chip: Rework irq_modify_status()kernel/ | +27 | 0 replies | |
| 28/45 | genirq/manage: Cleanup kernel doc commentskernel/ | +276 | 0 replies | |
| 29/45 | genirq/manage: Convert to lock guardskernel/ | +58 | 0 replies | |
| 30/45 | genirq/manage: Rework irq_update_affinity_desc()kernel/ | +32 | 0 replies | |
| 31/45 | genirq/manage: Rework __irq_apply_affinity_hint()kernel/ | +10 | 0 replies | |
| 32/45 | genirq/manage: Rework irq_set_vcpu_affinity()kernel/ | +17 | 1 reply | |
| 32/45 | genirq/manage: Rework irq_set_vcpu_affinity()kernel/ | +16 | 0 replies | |
| 33/45 | genirq/manage: Rework __disable_irq_nosync()kernel/ | +5 | 0 replies | |
| 34/45 | genirq/manage: Rework enable_irq()kernel/ | +6 | 0 replies | |
| 35/45 | genirq/manage: Rework irq_set_irq_wake()kernel/ | +28 | 2 replies | |
| 35/45 | genirq/manage: Rework irq_set_irq_wake()kernel/ | +30 | 3 replies | |
| 36/45 | genirq/manage: Rework can_request_irq()include/ kernel/ | +9 | 0 replies | |
| 37/45 | genirq/manage: Rework irq_set_parent()kernel/ | +5 | 0 replies | |
| 38/45 | genirq/manage: Rework enable_percpu_irq()kernel/ | +16 | 0 replies | |
| 39/45 | genirq/manage: Rework irq_percpu_is_enabled()kernel/ | +3 | 0 replies | |
| 40/45 | genirq/manage: Rework disable_percpu_irq()kernel/ | +2 | 0 replies | |
| 41/45 | genirq/manage: Rework prepare_percpu_nmi()kernel/ | +9 | 0 replies | |
| 42/45 | genirq/manage: Rework teardown_percpu_nmi()kernel/ | +5 | 0 replies | |
| 43/45 | genirq/manage: Rework irq_get_irqchip_state()kernel/ | +6 | 0 replies | |
| 44/45 | genirq/manage: Rework irq_set_irqchip_state()kernel/ | +20 | 0 replies | |
| 45/45 | genirq: Remove irq_[get|put]_desc*()kernel/ | +0 | 0 replies |
Reviews trailers per patch
2 of 48 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Jiri Slaby | Peter Zijlstra (Intel) |
|---|---|---|
| Series | A-b | |
| 1/45 | ||
| 2/45 | R-b | |
| 2/45 | R-b | |
| 3/45 | ||
| 4/45 | ||
| 5/45 | ||
| 6/45 | ||
| 7/45 | ||
| 8/45 | ||
| 9/45 | ||
| 10/45 | ||
| 11/45 | ||
| 12/45 | ||
| 13/45 | ||
| 14/45 | ||
| 15/45 | ||
| 16/45 | ||
| 17/45 | ||
| 18/45 | ||
| 19/45 | ||
| 20/45 | ||
| 21/45 | ||
| 22/45 | ||
| 23/45 | ||
| 24/45 | ||
| 25/45 | ||
| 26/45 | ||
| 27/45 | ||
| 28/45 | ||
| 29/45 | ||
| 30/45 | ||
| 31/45 | ||
| 32/45 | ||
| 32/45 | ||
| 33/45 | ||
| 34/45 | ||
| 35/45 | ||
| 35/45 | ||
| 36/45 | ||
| 37/45 | ||
| 38/45 | ||
| 39/45 | ||
| 40/45 | ||
| 41/45 | ||
| 42/45 | ||
| 43/45 | ||
| 44/45 | ||
| 45/45 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [patch V2 00/45] genirq: Cleanups and conversion to lock guards
This is V2 of the generic interrupt locking overhaul. V1 can be found here:
https://lore.kernel.org/all/[email protected]
The generic interrupt core code has accumulated quite some inconsistencies over time and a common pattern in various API functions is:
unsigned long flags;
struct irq_desc *desc = irq_get_desc_[bus]lock(irq, &flags, mode);
if (!desc)
return -EINVAL;
....
irq_put_desc_[bus]unlock(desc, flags);That's awkward and requires gotos in failure paths.
This series provides conditional lock guards and converts the core code over to use those guards. Along with that it converts the other open coded lock/unlock pairs and fixes up coding and kernel doc formatting. The conversions were partially done with Coccinelle where possible.
Changes vs. V1:
- Rebase on latest tip irq/core
- Make coding style consistent (Jiri, Shrikanth)
The series applies on
git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git irq/core
and is also available from git:
git://git.kernel.org/pub/scm/linux/kernel/git/tglx/devel.git irq/core
Thanks,
tglx
--- include/linux/irq.h | 2 kernel/irq/autoprobe.c | 26 - kernel/irq/chip.c | 609 ++++++++++--------------- kernel/irq/cpuhotplug.c | 10 kernel/irq/debugfs.c | 3 kernel/irq/internals.h | 47 - kernel/irq/irqdesc.c | 127 +---- kernel/irq/manage.c | 1154 ++++++++++++++++++++---------------------------- kernel/irq/pm.c | 38 - kernel/irq/proc.c | 65 -- kernel/irq/resend.c | 50 -- kernel/irq/spurious.c | 104 +--- 12 files changed, 913 insertions(+), 1322 deletions(-)