Skip to content

dso__data asan and test fixes

Ian Rogers linux-perf-users lkml 2 versions – Applied

Status from this message: Applied to perf-tools-next, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 1 replyApplied
  2. v13 patches 1 replySuperseded

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/3perf mutex: Add annotations for LOCKS_EXCLUDED and LOCKS_RETURNEDtools/perf/util/mutex.h+8 -00 replies
2/3perf dso: Use lock annotations to fix asan deadlocktools/perf/tests/dso-data.c tools/perf/util/dso.c tools/perf/util/dso.h +1 more+66 -430 replies
3/3perf test dso-data: Correctly free test file in read testtools/perf/tests/dso-data.c+12 -120 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/3] dso__data asan and test fixes

The dso__data logic could deadlock with itself when build with asan or reference count checking due to trying to recurively take a non-recursive mutex. Use clang's thread safety analysis to find/fix the problem. Running the tests would fail with -F no-fork mode as a file descriptor wasn't cleaned up.

v2: Remove an unnecessary if as suggested by Namhyung.

Ian Rogers (3):
perf mutex: Add annotations for LOCKS_EXCLUDED and LOCKS_RETURNED perf dso: Use lock annotations to fix asan deadlock perf test dso-data: Correctly free test file in read test

 tools/perf/tests/dso-data.c              | 28 ++++-----
 tools/perf/util/dso.c                    | 74 +++++++++++++++---------
 tools/perf/util/dso.h                    | 15 +++--
 tools/perf/util/mutex.h                  |  8 +++
 tools/perf/util/unwind-libunwind-local.c | 16 ++---
 5 files changed, 86 insertions(+), 55 deletions(-)
Signature · 1 line
2.49.0.rc1.451.g8f38331e32-goog