Skip to content

Add a deadline server for sched_ext tasks

Joel Fernandes bpf linux-kselftest lkml sched-ext 6 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest14 patches 1 replyIn review
  2. v514 patches 17 repliesSuperseded
  3. v415 patches 3 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v310 patches3 repliesSuperseded
v210 patches11 repliesSuperseded
v1 RFC8 patches14 repliesSuperseded

v4->v5 from the cover letter

- Added a kselftest (total_bw) to sched_ext to verify bandwidth values from debugfs.
- Address comment from Andrea about redundant rq clock invalidation.

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/14sched/debug: Fix updating of ppos on server write opskernel/sched/debug.c+4 -30 replies
2/14sched/debug: Stop and start server based on if it was activekernel/sched/debug.c+5 -20 replies
3/14sched/deadline: Clear the defer paramskernel/sched/deadline.c+3 -00 replies
4/14sched/deadline: Prevent setting server as started if params couldn't be appliedkernel/sched/deadline.c+3 -30 replies
5/14sched/deadline: Return EBUSY if dl_bw_cpus is zerokernel/sched/deadline.c+6 -11 reply
6/14sched: Add support to pick functions to take rfinclude/linux/sched.h kernel/sched/core.c kernel/sched/deadline.c +6 more+29 -250 replies
7/14sched: Add a server arg to dl_server_update_idle_time()kernel/sched/deadline.c kernel/sched/fair.c kernel/sched/idle.c +1 more+13 -110 replies
8/14sched/ext: Add a DL server for sched_ext taskskernel/sched/core.c kernel/sched/deadline.c kernel/sched/ext.c +1 more+66 -30 replies
9/14sched/debug: Add support to change sched_ext server paramskernel/sched/debug.c+129 -240 replies
10/14sched/deadline: Add support to remove DLserver's bandwidth contributionkernel/sched/deadline.c kernel/sched/sched.h+32 -00 replies
11/14sched/ext: Relinquish DL server reservations when not neededkernel/sched/ext.c+47 -90 replies
12/14selftests/sched_ext: Add test for sched_ext dl_servertools/testing/selftests/sched_ext/Makefile tools/testing/selftests/sched_ext/rt_stall.bpf.c tools/testing/selftests/sched_ext/rt_stall.c+237 -00 replies
13/14sched/deadline: Fix DL server crash in inactive_timer callbackkernel/sched/deadline.c+9 -30 replies
14/14selftests/sched_ext: Add test for DL server total_bw consistencytools/testing/selftests/sched_ext/Makefile tools/testing/selftests/sched_ext/total_bw.c+287 -00 replies

Reviews trailers per patch

6 of 14 patches have a Reviewed-by or Acked-by.

PatchAndrea RighiTejun Heo
1/14R-b A-b
2/14R-b A-b
3/14R-b
4/14
5/14
6/14R-b
7/14R-b
8/14R-b
9/14
10/14
11/14
12/14
13/14
14/14

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v6 thread

Cover letter [PATCH v6 00/14] Add a deadline server for sched_ext tasks

sched_ext tasks currently are starved by RT hoggers especially since RT throttling was replaced by deadline servers to boost only CFS tasks. Several users in the community have reported issues with RT stalling sched_ext tasks. Add a sched_ext deadline server as well so that sched_ext tasks are also boosted and do not suffer starvation.

2 kselftest are provided to verify the starvation fixes and bandwidth allocation is looking correct.

v5->v6: mostly no changes versus v5.
- Added Acks to few patches.
- Fixes to few nits suggested by Tejun.

v4->v5:
- Added a kselftest (total_bw) to sched_ext to verify bandwidth values from debugfs.
- Address comment from Andrea about redundant rq clock invalidation.

v3->v4:
- Fixed issues with hotplugged CPUs having their DL server bandwidth altered due to loading SCX.
- Fixed other issues.
- Rebased on Linus master.
- All sched_ext kselftests reliably pass now, also verified that the total_bw in debugfs (CONFIG_SCHED_DEBUG) is conserved with these patches.

v2->v3:
- Removed code duplication in debugfs. Made ext interface separate.
- Fixed issue where rq_lock_irqsave was not used in the relinquish patch.
- Fixed running bw accounting issue in dl_server_remove_params.

Link to v1: https://lore.kernel.org/all/[email protected]/
Link to v2: https://lore.kernel.org/all/[email protected]/
Link to v3: https://lore.kernel.org/all/[email protected]/
Link to v4: https://lore.kernel.org/all/[email protected]/
Link to v5: https://lore.kernel.org/all/[email protected]/

Andrea Righi (2):
sched/deadline: Add support to remove DLserver's bandwidth
contribution
selftests/sched_ext: Add test for sched_ext dl_server

Joel Fernandes (12):
sched/debug: Fix updating of ppos on server write ops sched/debug: Stop and start server based on if it was active sched/deadline: Clear the defer params
sched/deadline: Prevent setting server as started if params couldn't
be applied
sched/deadline: Return EBUSY if dl_bw_cpus is zero
sched: Add support to pick functions to take rf
sched: Add a server arg to dl_server_update_idle_time() sched/ext: Add a DL server for sched_ext tasks sched/debug: Add support to change sched_ext server params sched/ext: Relinquish DL server reservations when not needed sched/deadline: Fix DL server crash in inactive_timer callback selftests/sched_ext: Add test for DL server total_bw consistency

 include/linux/sched.h                         |   2 +-
 kernel/sched/core.c                           |  19 +-
 kernel/sched/deadline.c                       |  86 ++++--
 kernel/sched/debug.c                          | 165 ++++++++--
 kernel/sched/ext.c                            | 120 +++++++-
 kernel/sched/fair.c                           |  15 +-
 kernel/sched/idle.c                           |   4 +-
 kernel/sched/rt.c                             |   2 +-
 kernel/sched/sched.h                          |  13 +-
 kernel/sched/stop_task.c                      |   2 +-
 tools/testing/selftests/sched_ext/Makefile    |   2 +
 .../selftests/sched_ext/rt_stall.bpf.c        |  23 ++
 tools/testing/selftests/sched_ext/rt_stall.c  | 213 +++++++++++++
 tools/testing/selftests/sched_ext/total_bw.c  | 286 ++++++++++++++++++
 14 files changed, 869 insertions(+), 83 deletions(-)
 create mode 100644 tools/testing/selftests/sched_ext/rt_stall.bpf.c
 create mode 100644 tools/testing/selftests/sched_ext/rt_stall.c
 create mode 100644 tools/testing/selftests/sched_ext/total_bw.c
Signature · 1 line
2.34.1