Skip to content

PCI: Use device bus range info to cleanup RC Host/EP pci_fixup_addr()

Bjorn Helgaas imx linux-arm-kernel linux-devicetree linux-pci lkml 1 version Applied

Status from this message: Applied to pci/controller/dwc-cpu-addr-fixup for v6.15.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v12 Latest13 patches 22 repliesApplied

Changes in v12 from the cover letter

- Call devm_pci_alloc_host_bridge() early in dw_pcie_host_init(), before any devicetree-related code
- Call devm_pci_epc_create() early in dw_pcie_ep_init(), before any devicetree-related code
- Consolidate devicetree-related code in dw_pcie_host_get_resources() and dw_pcie_ep_get_resources()
- Integrate dw_pcie_cfg0_setup() into dw_pcie_host_get_resources()
- Convert dw_pcie_init_parent_bus_offset() to dw_pcie_parent_bus_offset() which returns the offset rather than setting it internally
- Split the debug comparison of devicetree info with .cpu_addr_fixup() to separate patch so we can easily revert it later
- Drop "cpu_addr_fixup() usage detected" warning since we always warn about something in that case anyway

Patches in v12 Applied

#Subject and filesSizeRepliesApplied
1/13PCI: dwc: Use resource start as iomap() input in dw_pcie_pme_turn_off()drivers/pci/controller/dwc/pcie-designware-host.c+1 -10 replies
2/13PCI: dwc: Rename cpu_addr to parent_bus_addr for ATU configurationdrivers/pci/controller/dwc/pcie-designware-ep.c drivers/pci/controller/dwc/pcie-designware-host.c drivers/pci/controller/dwc/pcie-designware.c +1 more+31 -300 replies
3/13PCI: dwc: Call devm_pci_alloc_host_bridge() early in dw_pcie_host_init()drivers/pci/controller/dwc/pcie-designware-host.c+6 -60 replies
4/13PCI: dwc: Consolidate devicetree handling in dw_pcie_host_get_resources()drivers/pci/controller/dwc/pcie-designware-host.c+25 -121 reply
5/13PCI: dwc: Add dw_pcie_parent_bus_offset()drivers/pci/controller/dwc/pcie-designware.c drivers/pci/controller/dwc/pcie-designware.h+26 -05 replies
6/13PCI: dwc: Add dw_pcie_parent_bus_offset() checking and debugdrivers/pci/controller/dwc/pcie-designware.c drivers/pci/controller/dwc/pcie-designware.h+38 -18 replies
7/13PCI: dwc: Use devicetree 'reg[config]' to derive CPU -> ATU addr offsetdrivers/pci/controller/dwc/pcie-designware-host.c drivers/pci/controller/dwc/pcie-designware.h+7 -00 replies
8/13PCI: dwc: ep: Call epc_create() early in dw_pcie_ep_init()drivers/pci/controller/dwc/pcie-designware-ep.c+9 -91 reply
9/13PCI: dwc: ep: Consolidate devicetree handling in dw_pcie_ep_get_resources()drivers/pci/controller/dwc/pcie-designware-ep.c+41 -271 reply
10/13PCI: dwc: ep: Use devicetree 'reg[addr_space]' to derive CPU -> ATU addr offsetdrivers/pci/controller/dwc/pcie-designware-ep.c+7 -01 reply
11/13PCI: dwc: ep: Ensure proper iteration over outbound map windowsdrivers/pci/controller/dwc/pcie-designware-ep.c+1 -10 replies
12/13PCI: dwc: Use parent_bus_offset to remove need for .cpu_addr_fixup()drivers/pci/controller/dwc/pcie-designware-ep.c drivers/pci/controller/dwc/pcie-designware-host.c drivers/pci/controller/dwc/pcie-designware.c+9 -111 reply
13/13PCI: imx6: Remove cpu_addr_fixup()drivers/pci/controller/dwc/pci-imx6.c+1 -170 replies

Reviews trailers per patch

4 of 13 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchManivannan SadhasivamRichard ZhuFrank Li
SeriesA-b T-b
1/13
2/13
3/13
4/13R-b
5/13
6/13
7/13
8/13R-b
9/13R-b
10/13
11/13
12/13
13/13R-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v12 thread

Cover letter [PATCH v12 00/13] PCI: Use device bus range info to cleanup RC Host/EP pci_fixup_addr()

From: Bjorn Helgaas <[email protected]>

This is a v12 based on Frank's v11 series.

v11 https://lore.kernel.org/r/[email protected]

Changes from v11:
- Call devm_pci_alloc_host_bridge() early in dw_pcie_host_init(), before any devicetree-related code
- Call devm_pci_epc_create() early in dw_pcie_ep_init(), before any devicetree-related code
- Consolidate devicetree-related code in dw_pcie_host_get_resources() and dw_pcie_ep_get_resources()
- Integrate dw_pcie_cfg0_setup() into dw_pcie_host_get_resources()
- Convert dw_pcie_init_parent_bus_offset() to dw_pcie_parent_bus_offset() which returns the offset rather than setting it internally
- Split the debug comparison of devicetree info with .cpu_addr_fixup() to separate patch so we can easily revert it later
- Drop "cpu_addr_fixup() usage detected" warning since we always warn about something in that case anyway

Any comments welcome.

Bjorn Helgaas (3):
PCI: dwc: Consolidate devicetree handling in
dw_pcie_host_get_resources()
PCI: dwc: ep: Call epc_create() early in dw_pcie_ep_init()
PCI: dwc: ep: Consolidate devicetree handling in
dw_pcie_ep_get_resources()

Frank Li (10):
PCI: dwc: Use resource start as iomap() input in

    dw_pcie_pme_turn_off()
  PCI: dwc: Rename cpu_addr to parent_bus_addr for ATU configuration
  PCI: dwc: Call devm_pci_alloc_host_bridge() early in
    dw_pcie_host_init()

PCI: dwc: Add dw_pcie_parent_bus_offset()
PCI: dwc: Add dw_pcie_parent_bus_offset() checking and debug
PCI: dwc: Use devicetree 'reg[config]' to derive CPU -> ATU addr
offset
PCI: dwc: ep: Use devicetree 'reg[addr_space]' to derive CPU -> ATU
addr offset
PCI: dwc: ep: Ensure proper iteration over outbound map windows
PCI: dwc: Use parent_bus_offset to remove need for .cpu_addr_fixup()
PCI: imx6: Remove cpu_addr_fixup()

 drivers/pci/controller/dwc/pci-imx6.c         | 18 +---
 .../pci/controller/dwc/pcie-designware-ep.c   | 74 +++++++++++------
 .../pci/controller/dwc/pcie-designware-host.c | 57 ++++++++-----
 drivers/pci/controller/dwc/pcie-designware.c  | 82 ++++++++++++++-----
 drivers/pci/controller/dwc/pcie-designware.h  | 24 +++++-
 5 files changed, 171 insertions(+), 84 deletions(-)
Signature · 1 line
2.34.1