Skip to content

iio:light: add driver for veml6046x00 RGBIR color sensor

Andreas Klinger linux-devicetree linux-iio lkml 7 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v7 Latest3 patches 2 repliesIn review
  2. v63 patches 8 repliesSuperseded
  3. v53 patches 4 repliesSuperseded
Earlier versions · 4
VersionPostedPatchesRepliesStatus
v43 patches4 repliesSuperseded
v33 patches3 repliesSuperseded
v23 patches2 repliesSuperseded
v13 patches14 repliesSuperseded

Changes in v7 from the cover letter

- Thanks to the reviews of Jonathan and Andy improvements in the PM could be implemented like removal of pm_runtime_mark_last_busy() and consistency in PM handling in some functions.

Patches in v7 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3dt-bindings: iio: light: veml6046x00: add color sensorDocumentation/devicetree/bindings/iio/light/vishay,veml6046x00.yaml+51 -00 replies
2/3iio: light: add support for veml6046x00 RGBIR color sensordrivers/iio/light/Kconfig drivers/iio/light/Makefile drivers/iio/light/veml6046x00.c+1045 -01 reply
3/3MAINTAINER: add maintainer for veml6046x00MAINTAINERS+6 -00 replies

Reviews trailers per patch

1 of 3 patches has a Reviewed-by or Acked-by.

PatchKrzysztof Kozlowski
1/3R-b
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v7 thread

Cover letter [PATCH v7 0/3] iio:light: add driver for veml6046x00 RGBIR color sensor

This patchset adds an IIO driver for Vishay veml6046x00 RGBIR color sensor.

Changes in v7:
- Thanks to the reviews of Jonathan and Andy improvements in the PM could be implemented like removal of pm_runtime_mark_last_busy() and consistency in PM handling in some functions.

Changes in v6:
- Thanks to the in-depth review of Andy many datatype improvements were realized.
- According to Jonathans review change the channel types from IIO_LIGHT to IIO_INTENSITY.

Changes in v5:
- Thanks to the feedback of Andy and further explanations of Jonathan many improvements could be implemented.
- add documentation in kernel-doc format
- iio_push_to_buffers_with_ts() is not used as also testing against linux-stable where it is not available so far.

Changes in v4:
- implement feedback from Andy and Jonathan
- implement feedback from vendor (reading interrupt register as bulk read)

Changes in v3:
- implement a lot of feedback from Jonathan
- change scale value to real factor of lux per raw count instead of hardware gain
- optimize code by using more lookup tables
- remove unimplemented threshold functionality

Changes in v2:
- fix missing include for example in vishay,veml6046x00.yaml

Andreas Klinger (3):
dt-bindings: iio: light: veml6046x00: add color sensor
iio: light: add support for veml6046x00 RGBIR color sensor
MAINTAINER: add maintainer for veml6046x00

 .../iio/light/vishay,veml6046x00.yaml         |   51 +
 MAINTAINERS                                   |    6 +
 drivers/iio/light/Kconfig                     |   13 +
 drivers/iio/light/Makefile                    |    1 +
 drivers/iio/light/veml6046x00.c               | 1031 +++++++++++++++++
 5 files changed, 1102 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/iio/light/vishay,veml6046x00.yaml
 create mode 100644 drivers/iio/light/veml6046x00.c
Signature · 1 line
2.39.5