spi: tegra210-quad: Improve messages on pathological case
Get series with b4
b4 am [email protected] change-id 20250317-tegra-1712e60604e6Versions newest first
- v2 Latest2 patches 1 replyIn review
- v13 patches 25 repliesSuperseded
Changes in v2 from the cover letter
- Dropped patch 1, which is still being discussed.
* See https://lore.kernel.org/all/20250328-cinnamon-mushroom-of-proficiency-a17ba8@leitao/
- Link to v1: https://lore.kernel.org/r/[email protected]
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | spi: tegra210-quad: use WARN_ON_ONCE instead of WARN_ON for timeoutsdrivers/ | +1 | 0 replies | |
| 2/2 | spi: tegra210-quad: add rate limiting and simplify timeout error messagedrivers/ | +2 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.
Cover letter [PATCH v2 0/2] spi: tegra210-quad: Improve messages on pathological case
I maintain several hosts with tegra210-quad controllers, some of which experience data transmission failures. Debugging these issues has been challenging due to excessive log messages from the driver.
Since these devices do not have a way to reset[1], then we want to avoid warning and printing a bunch of messages, otherwise the host will overflow the serial. Fix it by:
1. Using WARN_ON_ONCE instead of WARN_ON to reduce stack trace spam
2. Rate-limiting error messages and removing redundant information
These improvements maintain necessary error reporting while significantly reducing log noise, making debugging of actual issues more feasible.
---
Changes in v2:
- Dropped patch 1, which is still being discussed.
* See https://lore.kernel.org/all/20250328-cinnamon-mushroom-of-proficiency-a17ba8@leitao/
- Link to v1: https://lore.kernel.org/r/[email protected]
---
Breno Leitao (2):
spi: tegra210-quad: use WARN_ON_ONCE instead of WARN_ON for timeouts
spi: tegra210-quad: add rate limiting and simplify timeout error message
drivers/spi/spi-tegra210-quad.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
---
base-commit: 4701f33a10702d5fc577c32434eb62adde0a1ae1
change-id: 20250317-tegra-1712e60604e6
Best regards,
Signature · 1 line
Breno Leitao <[email protected]>