Skip to content

sched: Make CONFIG_SCHED_DEBUG features unconditional

Ingo Molnar lkml 1 version Applied

Status from this message: The following commit has been merged into the sched/core branch of tip:

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 11 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/5sched/debug: Change SCHED_WARN_ON() to WARN_ON_ONCE()kernel/sched/core.c kernel/sched/core_sched.c kernel/sched/deadline.c +5 more+56 -629 replies
2/5sched/debug: Make 'const_debug' tunables unconditional __read_mostlykernel/sched/core.c kernel/sched/fair.c kernel/sched/sched.h+8 -130 replies
3/5sched/debug: Make CONFIG_SCHED_DEBUG functionality unconditionalfs/proc/base.c include/linux/energy_model.h include/linux/sched/debug.h +9 more+9 -1080 replies
4/5sched/debug, Documentation: Remove (most) CONFIG_SCHED_DEBUG references from documentationDocumentation/scheduler/sched-debug.rst Documentation/scheduler/sched-design-CFS.rst Documentation/scheduler/sched-domains.rst +3 more+7 -90 replies
5/5sched/debug: Remove CONFIG_SCHED_DEBUGlib/Kconfig.debug+0 -91 reply

Reviews trailers per patch

None of the 5 patches has a Reviewed-by or Acked-by.

PatchShrikanth HegdeIngo Molnar
SeriesT-b
1/5Totally-Not-Signed-off-by Not-Signed-off-by
2/5
3/5
4/5
5/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/5] sched: Make CONFIG_SCHED_DEBUG features unconditional

For more than a decade, CONFIG_SCHED_DEBUG=y has been enabled in all the major Linux distributions:

/boot/config-6.11.0-19-generic:CONFIG_SCHED_DEBUG=y

The reason is that while originally CONFIG_SCHED_DEBUG started out as a debugging feature, over the years (decades ...) it has grown various bits of statistics, instrumentation and control knobs that are useful for sysadmin and general software development purposes as well.

But within the kernel we still pretend that there's a choice, and sometimes code that is seemingly 'debug only' creates overhead that should be optimized in reality.

So make it all official and make CONFIG_SCHED_DEBUG unconditional. This gets rid of a large amount of #ifdefs, so good riddance ...

Ingo Molnar (5):
sched/debug: Change SCHED_WARN_ON() to WARN_ON_ONCE()
sched/debug: Make 'const_debug' tunables unconditional __read_mostly sched/debug: Make CONFIG_SCHED_DEBUG functionality unconditional sched/debug, Documentation: Remove (most) CONFIG_SCHED_DEBUG references from documentation sched/debug: Remove CONFIG_SCHED_DEBUG

 Documentation/scheduler/sched-debug.rst                         |  2 +-
 Documentation/scheduler/sched-design-CFS.rst                    |  2 +-
 Documentation/scheduler/sched-domains.rst                       |  5 +-
 Documentation/scheduler/sched-ext.rst                           |  3 +-
 Documentation/scheduler/sched-stats.rst                         |  2 +-
 Documentation/translations/sp_SP/scheduler/sched-design-CFS.rst |  2 +-
 fs/proc/base.c                                                  |  7 ---
 include/linux/energy_model.h                                    |  2 -
 include/linux/sched/debug.h                                     |  2 -
 include/linux/sched/topology.h                                  |  4 --
 include/trace/events/sched.h                                    |  2 -
 kernel/sched/build_utility.c                                    |  4 +-
 kernel/sched/core.c                                             | 46 ++++++----------
 kernel/sched/core_sched.c                                       |  2 +-
 kernel/sched/deadline.c                                         | 14 +++--
 kernel/sched/ext.c                                              |  2 +-
 kernel/sched/fair.c                                             | 64 +++++++++++-----------
 kernel/sched/rt.c                                               |  7 +--
 kernel/sched/sched.h                                            | 83 +++++------------------------
 kernel/sched/stats.h                                            |  2 +-
 kernel/sched/topology.c                                         | 13 -----
 lib/Kconfig.debug                                               |  9 ----
 22 files changed, 79 insertions(+), 200 deletions(-)
Signature · 1 line
2.45.2