Skip to content

net: fix bugs and error handling in qinheng ch9200 driver and mii interface

Qasim Ijaz linux-usb lkml netdev stable 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 11 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4net: fix uninitialised access in mii_nway_restart()drivers/net/mii.c drivers/net/usb/ch9200.c+7 -26 replies
2/4net: ch9200: remove extraneous return in control_write() to propagate failuresdrivers/net/usb/ch9200.c+0 -21 reply
3/4net: ch9200: improve error handling in get_mac_address()drivers/net/usb/ch9200.c+19 -132 replies
4/4net: ch9200: add error handling in ch9200_bind()drivers/net/usb/ch9200.c+15 -32 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchsyzbotSimon Horman
1/4T-b R-b
2/4R-b
3/4R-b
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/4] net: fix bugs and error handling in qinheng ch9200 driver and mii interface

This patch series aims to fix various issues throughout the QinHeng CH9200 driver. This driver fails to handle failures throughout, which in one case has lead to a uninit access bug found via syzbot. Upon reviewing the driver I fixed a few more issues which I have included in this patch series.

Parts of this series are the product of discussions and suggestions I had from others like Andrew Lunn and Simon Horman, you can view those discussions below:

Qasim Ijaz (4):
fix uninitialised access in mii_nway_restart()
remove extraneous return in control_write() to propagate failures improve error handling in get_mac_address()
add error handling in ch9200_bind()

 drivers/net/mii.c        |  2 ++
 drivers/net/usb/ch9200.c | 59 ++++++++++++++++++++++++++--------------
 2 files changed, 41 insertions(+), 20 deletions(-)
Signature · 1 line
2.39.5