Skip to content

Implement TryFrom<&Device> for bus specific devices

Danilo Krummrich linux-pci lkml rust-for-linux 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest3 patches 16 repliesIn review
  2. v33 patches 0 repliesSuperseded
  3. v24 patches 18 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v14 patches9 repliesSuperseded

Changes in v4 from the cover letter

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3rust: device: implement bus_type_raw()rust/kernel/device.rs+10 -01 reply
2/3rust: pci: impl TryFrom<&Device> for &pci::Devicerust/kernel/device.rs rust/kernel/pci.rs+23 -313 replies
3/3rust: platform: impl TryFrom<&Device> for &platform::Devicerust/kernel/platform.rs+23 -21 reply

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchAlice RyhlBenno LossinGreg Kroah-Hartman
1/3R-b R-b R-b
2/3R-b R-b
3/3R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v4 thread

Cover letter [PATCH v4 0/3] Implement TryFrom<&Device> for bus specific devices

This series provides a mechanism to safely convert a struct device into its corresponding bus specific device instance, if any.

In C a generic struct device is typically converted to a specific bus device with container_of(). This requires the caller to know whether the generic struct device is indeed embedded within the expected bus specific device type.

In Rust we can do the same thing by implementing the TryFrom trait, e.g.

impl TryFrom<&Device> for pci::Device

This is a safe operation, since we can check whether dev->bus equals the the expected struct bus_type.

A branch containing the patches can be found in [1].

This is needed for the auxiliary bus abstractions and connecting nova-core with nova-drm. [2]

[1] https://web.git.kernel.org/pub/scm/linux/kernel/git/dakr/linux.git/log/?h=rust/device
[2] https://gitlab.freedesktop.org/drm/nova/-/tree/staging/nova-drm

Changes in v4:
- work around a minor issue in rustc < 1.82
- https://blog.rust-lang.org/2024/10/17/Rust-1.82.0.html#safely-addressing-unsafe-statics

Changes in v3:
- drop patch to add Device::parent(), will make it crate private and part of the auxbus series
- safety comment: clarify that a device' bus type is guaranteed to be set correctly by the corresponding C code

Changes in v2:
- s/unsafe { *self.as_raw() }.parent/unsafe { (*self.as_raw()).parent }/
- expand safety comment on Device::bus_type_raw()

Danilo Krummrich (3):
rust: device: implement bus_type_raw()
rust: pci: impl TryFrom<&Device> for &pci::Device
rust: platform: impl TryFrom<&Device> for &platform::Device

 rust/kernel/device.rs   |  9 +++++++++
 rust/kernel/pci.rs      | 25 +++++++++++++++++++++++--
 rust/kernel/platform.rs | 25 +++++++++++++++++++++++--
 3 files changed, 55 insertions(+), 4 deletions(-)

base-commit: 51d0de7596a458096756c895cfed6bc4a7ecac10

Signature · 1 line
2.48.1