Skip to content

Additional methods for Vec

Alice Ryhl lkml rust-for-linux 5 versions – Applied

Status from this message: Applied to alloc-next, thanks!

Get series with b4
b4 am [email protected] change-id 20250320-vec-methods-adfa41e55311

Versions newest first

  1. v5 Latest7 patches 16 repliesApplied
  2. v47 patches 19 repliesSuperseded
  3. v37 patches 14 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v27 patches5 repliesSuperseded
v15 patches9 repliesSuperseded

Changes in v5 from the cover letter

- Replace panics with errors.
- Avoid variable for length in drain_all.
- Link to v4: https://lore.kernel.org/r/[email protected]

Patches in v5 Applied

#Subject and filesSizeRepliesApplied
1/7rust: alloc: add Vec::clearrust/kernel/alloc/kvec.rs+20 -00 replies
2/7rust: alloc: add Vec::poprust/kernel/alloc/kvec.rs+31 -01 reply
3/7rust: alloc: add Vec::push_within_capacityrust/kernel/alloc/kvec.rs rust/kernel/alloc/kvec/errors.rs+65 -44 replies
4/7rust: alloc: add Vec::drain_allrust/kernel/alloc/kvec.rs+59 -01 reply
5/7rust: alloc: add Vec::retainrust/kernel/alloc/kvec.rs+72 -01 reply
6/7rust: alloc: add Vec::removerust/kernel/alloc/kvec.rs rust/kernel/alloc/kvec/errors.rs+56 -16 replies
7/7rust: alloc: add Vec::insert_within_capacityrust/kernel/alloc/kvec.rs rust/kernel/alloc/kvec/errors.rs+73 -11 reply

Reviews trailers per patch

All 7 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchBenno LossinTamir DubersteinGreg Kroah-Hartman
SeriesR-b
1/7R-b R-b
2/7R-b
3/7R-b
4/7R-b
5/7R-b
6/7R-b
7/7R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v5 thread

Cover letter [PATCH v5 0/7] Additional methods for Vec

This adds various Vec methods. Some of them are needed by Rust Binder, and others are needed in other places. Each commit explains where it is needed.

This series is based on top of alloc-next and rust: alloc: split Vec::set_len into Vec::{inc,dec}_len
https://lore.kernel.org/rust-for-linux/[email protected]/

---
Changes in v5:
- Replace panics with errors.
- Avoid variable for length in drain_all.
- Link to v4: https://lore.kernel.org/r/[email protected]

Changes in v4:
- Add missing ? in some doc tests.
- Fix safety comment in Vec::push_within_capacity.
- Add panics section to Vec::remove docs.
- Move self.dec_len(1) to end of Vec::remove.
- Add kunit test for Vec::retain.
- Link to v3: https://lore.kernel.org/r/[email protected]

Changes in v3:
- Rebase on split Vec::set_len into Vec::{inc,dec}_len.
- Various modifications to work with inc/dec_len instead of set_len,
with some Reviewed-by's dropped due to this.
- Move push_within_capacity impl into an unchecked variant.
- Link to v2: https://lore.kernel.org/r/[email protected]

Changes in v2:
- Add two more methods that I needed.
- Introduce some uses of set_len.
- Add example to retain.
- Simplify pop.
- Adjust 11 to 10 in push_within_capacity example.
- Link to v1: https://lore.kernel.org/r/[email protected]

---
Alice Ryhl (7):
rust: alloc: add Vec::clear
rust: alloc: add Vec::pop
rust: alloc: add Vec::push_within_capacity
rust: alloc: add Vec::drain_all
rust: alloc: add Vec::retain
rust: alloc: add Vec::remove
rust: alloc: add Vec::insert_within_capacity

 rust/kernel/alloc/kvec.rs        | 315 ++++++++++++++++++++++++++++++++++++++-
 rust/kernel/alloc/kvec/errors.rs |  61 ++++++++
 2 files changed, 373 insertions(+), 3 deletions(-)

---
base-commit: 88d5d6a38d5161228fbfe017eb94d777d5e8a0e4
change-id: 20250320-vec-methods-adfa41e55311

Best regards,

Signature · 1 line
Alice Ryhl <[email protected]>