Skip to content

drm/xe/guc: Add LFD format output for guc log

Zhanjun Dong intel-xe 8 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v8 Latest6 patches 3 repliesIn review
  2. v76 patches 11 repliesSuperseded
  3. v66 patches 19 repliesSuperseded
Earlier versions · 5
VersionPostedPatchesRepliesStatus
v56 patches0 repliesSuperseded
v46 patches9 repliesSuperseded
v34 patches13 repliesSuperseded
v22 patches7 repliesSuperseded
v11 patch2 repliesSuperseded

Changes in v8 from the cover letter

Kernel-doc fix (Michal)
Update chunk end and size check (Julia)
Rebase with baseline changes

Patches in v8 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6drm/xe/guc: Add log init config abi definitionsdrivers/gpu/drm/xe/abi/guc_lic_abi.h+77 -00 replies
2/6drm/xe/guc: Add LFD related abi definitionsdrivers/gpu/drm/xe/abi/guc_lfd_abi.h+171 -00 replies
3/6drm/xe/guc: Add GuC log init config in LFD formatdrivers/gpu/drm/xe/xe_guc_log.c+266 -10 replies
4/6drm/xe/guc: Add GuC log event buffer output in LFD formatdrivers/gpu/drm/xe/xe_guc_log.c+76 -11 reply
5/6drm/xe/guc: Only add GuC crash dump if availabledrivers/gpu/drm/xe/xe_guc_log.c+45 -01 reply
6/6drm/xe/guc: Add new debugfs entry for lfd format outputdrivers/gpu/drm/xe/xe_guc_debugfs.c drivers/gpu/drm/xe/xe_guc_log.c drivers/gpu/drm/xe/xe_guc_log.h+23 -30 replies

Reviews trailers per patch

All 6 patches have a Reviewed-by or Acked-by.

PatchJulia Filipchuk
1/6R-b
2/6R-b
3/6R-b
4/6R-b
5/6R-b
6/6R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v8 thread

Cover letter [PATCH v8 0/6] drm/xe/guc: Add LFD format output for guc log

Add new debugfs entry "guc_log_lfd", which supports output guc log in LFD(Log Format Descriptors) format.
Add GuC crash dump data empty check. LFD will only include crash dump section when data is not empty.

---
Cc: Michal Wajdeczko <[email protected]>
Cc: Jonathan Cavitt <[email protected]>
Cc: Matthew Brost <[email protected]>
Cc: Julia Filipchuk <[email protected]>

Changes in v8:
Kernel-doc fix (Michal)
Update chunk end and size check (Julia)
Rebase with baseline changes
Changes in v7:
Process log buffer layout by marker detect, not by index
Move debugfs support to end of series
Drop version structures, replaced as an single u32
Switch to use local structure from local buffer
Output lfd in binary format
Use wrap_offset for log event buffer for wraparound handling
As crash dump is very small, remove cross chunk handling
Changes in v6:
Replace log_init_config to lic
Changes in v5:
Cleanup inconsistent macro, type and symbol names (Michal) Switch to use 1K local stack for buffer usage (Michal)
Changes in v4:
Rebase with debugfs changes (Michal)
Drop "_t" suffix in structures name (Matthew, Michal)
Split log abi header as seperate patch (Michal)
Fix static vaiable multiple instance access issue (Michal) Switched to fixed size(2M) of lfd buffer, removed buffer size check for KLVs Removed log event buffer content copy, read from log buffer chunks directly Changes in v3:
Split ABI header, debugfs and GuC code out as seperate patch Remove bit fields in structure define, changed to GENMASK
Remove crash_dumped flag, changed to dump data empty check Changes in v2:
Split GuC init config abi defines out from LFD abi header file Split crash dump detect as seperate patch
Add size check for LFD functions
Make abi header comments kernel-doc style

Zhanjun Dong (6):
drm/xe/guc: Add log init config abi definitions drm/xe/guc: Add LFD related abi definitions drm/xe/guc: Add GuC log init config in LFD format drm/xe/guc: Add GuC log event buffer output in LFD format drm/xe/guc: Only add GuC crash dump if available drm/xe/guc: Add new debugfs entry for lfd format output

 drivers/gpu/drm/xe/abi/guc_lfd_abi.h | 171 ++++++++++++
 drivers/gpu/drm/xe/abi/guc_lic_abi.h |  77 ++++++
 drivers/gpu/drm/xe/xe_guc_debugfs.c  |   7 +
 drivers/gpu/drm/xe/xe_guc_log.c      | 399 ++++++++++++++++++++++++++-
 drivers/gpu/drm/xe/xe_guc_log.h      |   1 +
 5 files changed, 654 insertions(+), 1 deletion(-)
 create mode 100644 drivers/gpu/drm/xe/abi/guc_lfd_abi.h
 create mode 100644 drivers/gpu/drm/xe/abi/guc_lic_abi.h
Signature · 1 line
2.34.1