Skip to content

Add DAPM/ASoC helpers to create SDCA drivers

Charles Keepax linux-sound 6 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest7 patches 2 repliesIn review
  2. v56 patches 19 repliesSuperseded
  3. v45 patches 0 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v33 patches1 replySuperseded
v23 patches2 repliesSuperseded
v13 patches7 repliesSuperseded

Changes in v6 from the cover letter

- Add small typo fixup patch.
- Move and add some comments.
- Switch from fixed poll time to fixed number of polls waiting for PDEs.
- Generate read only ALSA controls where appropriate.
- Export ALSA controls for SDCA controls with fixed values.
- Clamp control values to range supported by ALSA.
- Force export of a control for DETECTED_MODE.

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7ASoC: SDCA: Fix minor typoinclude/sound/sdca_function.h+1 -10 replies
2/7ASoC: SDCA: Remove regmap module macrossound/soc/sdca/sdca_regmap.c+0 -30 replies
3/7ASoC: SDCA: Move allocation of PDE delays arraysound/soc/sdca/sdca_functions.c+4 -60 replies
4/7ASoC: dapm: Add component level pin switchesinclude/sound/soc-dapm.h sound/soc/soc-dapm.c+74 -140 replies
5/7ASoC: SDCA: Create DAPM widgets and routes from DisCoinclude/sound/sdca_asoc.h include/sound/sdca_function.h sound/soc/sdca/Makefile +1 more+911 -10 replies
6/7ASoC: SDCA: Create ALSA controls from DisCoinclude/sound/sdca_asoc.h include/sound/sdca_function.h sound/soc/sdca/sdca_asoc.c+267 -50 replies
7/7ASoC: SDCA: Create DAI drivers from DisCoinclude/sound/sdca_asoc.h include/sound/sdca_function.h sound/soc/sdca/sdca_asoc.c+256 -60 replies

Reviews trailers per patch

None of the 7 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchPierre-Louis Bossart
SeriesR-b
1/7
2/7
3/7
4/7
5/7
6/7
7/7

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v6 thread

Cover letter [PATCH v6 0/7] Add DAPM/ASoC helpers to create SDCA drivers

Add helper functions to add DAPM widgets, routes, ALSA controls, and DAI drivers, these will be used to create SDCA function device drivers.

This series should provide most of the core functionality needed to get a device registered and have a working DAPM graph within the device. There are some features that still need additional work, these are marked with FIXMEs in the code. The two main things are SDCA Clock Muxes (not used in our devices and needs some ASoC core work), and better support for more complex SDCA volume control definitions (our parts have fairly simple volumes, and SDCA has a large amount of flexibility in how the volume control is specified).

The next steps in the process are to add helpers for the DAI ops themselves, some IRQ handling, and firmware download. And finally we should be able to actually add the SDCA class driver itself.

Thanks,
Charles

Changes since v5:
- Add small typo fixup patch.
- Move and add some comments.
- Switch from fixed poll time to fixed number of polls waiting for PDEs.
- Generate read only ALSA controls where appropriate.
- Export ALSA controls for SDCA controls with fixed values.
- Clamp control values to range supported by ALSA.
- Force export of a control for DETECTED_MODE.

Charles Keepax (7):
ASoC: SDCA: Fix minor typo
ASoC: SDCA: Remove regmap module macros
ASoC: SDCA: Move allocation of PDE delays array
ASoC: dapm: Add component level pin switches
ASoC: SDCA: Create DAPM widgets and routes from DisCo
ASoC: SDCA: Create ALSA controls from DisCo
ASoC: SDCA: Create DAI drivers from DisCo

 include/sound/sdca_asoc.h       |   42 +
 include/sound/sdca_function.h   |   71 +-
 include/sound/soc-dapm.h        |    4 +
 sound/soc/sdca/Makefile         |    2 +-
 sound/soc/sdca/sdca_asoc.c      | 1311 +++++++++++++++++++++++++++++++
 sound/soc/sdca/sdca_functions.c |   10 +-
 sound/soc/sdca/sdca_regmap.c    |    3 -
 sound/soc/soc-dapm.c            |   84 +-
 8 files changed, 1502 insertions(+), 25 deletions(-)
 create mode 100644 include/sound/sdca_asoc.h
 create mode 100644 sound/soc/sdca/sdca_asoc.c
Signature · 1 line
2.39.5