Skip to content

bcachefs stack usage improvements

Kent Overstreet linux-bcachefs 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest8 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8bcachefs: Kill unnecessary bch2_dev_usage_read()fs/bcachefs/alloc_foreground.c+1 -10 replies
2/8bcachefs: Kill btree_iter.transfs/bcachefs/acl.c fs/bcachefs/alloc_background.c fs/bcachefs/alloc_foreground.c +38 more+400 -4010 replies
3/8bcachefs: do_trace_key_cache_fill()fs/bcachefs/btree_key_cache.c+15 -90 replies
4/8bcachefs: bch2_alloc_to_v4() no longer converts on stackfs/bcachefs/alloc_background.c fs/bcachefs/alloc_background.h fs/bcachefs/alloc_foreground.c +5 more+82 -290 replies
5/8bcachefs: Move cycle detector state to btree_transfs/bcachefs/btree_locking.c fs/bcachefs/btree_locking_types.h fs/bcachefs/btree_types.h+42 -310 replies
6/8bcachefs: struct alloc_requestfs/bcachefs/alloc_foreground.c fs/bcachefs/alloc_foreground.h fs/bcachefs/ec.c +2 more+176 -2370 replies
7/8bcachefs: alloc_request.data_typefs/bcachefs/alloc_foreground.c fs/bcachefs/alloc_foreground.h fs/bcachefs/ec.c+11 -150 replies
8/8bcachefs: bch2_bucket_alloc_trans() takes alloc_requestfs/bcachefs/alloc_foreground.c+19 -180 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/8] bcachefs stack usage improvements

We overran the stack in a kmsan replication test.

Stack usage in non kmsan builds isn't critical; it appears that our kmsan builds are particularly bad for stack usage because it inserts additional function calls between each real function call, and we do have some very deeply nested call stacks. The deepest I observed was:

- transaction commit
- btree split
- btree node allocation
- sector allocator, bucket allocator
- runtime alloc info fsck checks (we don't actually do repair inline, fortunately).
- btree_iter_peek_slot
- key cache traverse, fill
- btree_iter_peek_slot and pathwalk for normal btree lookup

This series is sufficient for now, and might go into 6.15 if I'm happy with how the test dashboard looks. Later on I'll be moving more things into alloc_request and moving it off the stack entirely, allocating it with the btree_trans bump allocator.

Some items for btree node pathwalk might get moved into btree_trans as well.

Kent Overstreet (8):
bcachefs: Kill unnecessary bch2_dev_usage_read()
bcachefs: Kill btree_iter.trans
bcachefs: do_trace_key_cache_fill()
bcachefs: bch2_alloc_to_v4() no longer converts on stack
bcachefs: Move cycle detector state to btree_trans
bcachefs: struct alloc_request
bcachefs: alloc_request.data_type
bcachefs: bch2_bucket_alloc_trans() takes alloc_request

 fs/bcachefs/acl.c                   |   4 +-
 fs/bcachefs/alloc_background.c      | 132 ++++++-----
 fs/bcachefs/alloc_background.h      |  23 +-
 fs/bcachefs/alloc_foreground.c      | 342 +++++++++++-----------------
 fs/bcachefs/alloc_foreground.h      |  25 +-
 fs/bcachefs/backpointers.c          |  12 +-
 fs/bcachefs/btree_gc.c              |   8 +-
 fs/bcachefs/btree_io.c              |   3 +-
 fs/bcachefs/btree_iter.c            | 184 +++++++--------
 fs/bcachefs/btree_iter.h            | 122 +++++-----
 fs/bcachefs/btree_key_cache.c       |  32 +--
 fs/bcachefs/btree_locking.c         |  43 +---
 fs/bcachefs/btree_locking_types.h   |  28 +++
 fs/bcachefs/btree_types.h           |   3 +-
 fs/bcachefs/btree_update.c          |  26 +--
 fs/bcachefs/btree_update_interior.c |  12 +-
 fs/bcachefs/btree_write_buffer.c    |  10 +-
 fs/bcachefs/buckets.c               |   2 +-
 fs/bcachefs/data_update.c           |   8 +-
 fs/bcachefs/dirent.c                |  16 +-
 fs/bcachefs/disk_accounting.c       |   4 +-
 fs/bcachefs/ec.c                    |  64 +++---
 fs/bcachefs/extent_update.c         |   6 +-
 fs/bcachefs/fs-io-buffered.c        |   6 +-
 fs/bcachefs/fs-io.c                 |  10 +-
 fs/bcachefs/fs.c                    |  22 +-
 fs/bcachefs/fsck.c                  |  30 +--
 fs/bcachefs/inode.c                 |  18 +-
 fs/bcachefs/io_misc.c               |  18 +-
 fs/bcachefs/io_read.c               |   8 +-
 fs/bcachefs/io_write.c              |  12 +-
 fs/bcachefs/io_write.h              |  28 ---
 fs/bcachefs/io_write_types.h        |  28 +++
 fs/bcachefs/lru.c                   |   9 +-
 fs/bcachefs/migrate.c               |   4 +-
 fs/bcachefs/move.c                  |  12 +-
 fs/bcachefs/movinggc.c              |   2 +-
 fs/bcachefs/namei.c                 |  38 ++--
 fs/bcachefs/quota.c                 |   2 +-
 fs/bcachefs/rebalance.c             |  12 +-
 fs/bcachefs/recovery.c              |   6 +-
 fs/bcachefs/reflink.c               |  23 +-
 fs/bcachefs/snapshot.c              |  10 +-
 fs/bcachefs/str_hash.c              |   2 +-
 fs/bcachefs/str_hash.h              |   8 +-
 fs/bcachefs/subvolume.c             |   4 +-
 fs/bcachefs/subvolume.h             |  14 +-
 fs/bcachefs/tests.c                 |  30 +--
 fs/bcachefs/xattr.c                 |   2 +-
 49 files changed, 736 insertions(+), 731 deletions(-)
 create mode 100644 fs/bcachefs/btree_locking_types.h
Signature · 1 line
2.49.0