Skip to content

RFC nvme-tcp: Implement TP4129 (KATO Corrections and Clarifications)

Mohamed Khalfella linux-nvme lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest7 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7nvme-core: Read CQT wait from identify controller responsedrivers/nvme/host/core.c drivers/nvme/host/nvme.h include/linux/nvme.h+5 -10 replies
2/7nvmef: Add nvmef_req_hold_timeout_ms() to calculate kato request hold timedrivers/nvme/host/fabrics.h+7 -00 replies
3/7nvme-tcp: Move freeing tagset out of nvme_tcp_teardown_io_queues()drivers/nvme/host/tcp.c+7 -80 replies
4/7nvme-tcp: Move freeing admin tagset out of nvme_tcp_teardown_admin_queue()drivers/nvme/host/tcp.c+10 -90 replies
5/7nvme-tcp: Split nvme_tcp_teardown_io_queues() into two functionsdrivers/nvme/host/tcp.c+9 -10 replies
6/7nvme-core: Add support for holding inflight requestsdrivers/nvme/host/core.c drivers/nvme/host/nvme.h+65 -00 replies
7/7nvme-tcp: Do not immediately cancel inflight requests during recoverydrivers/nvme/host/tcp.c+20 -100 replies

Reviews trailers per patch

None of the 7 patches has a Reviewed-by or Acked-by.

PatchShai Dagieli
SeriesT-b
1/7
2/7
3/7
4/7
5/7
6/7
7/7

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [RFC PATCH v1 0/7] nvme-tcp: Implement TP4129 (KATO Corrections and Clarifications)

Hello,

RFC patchset implementing TP4129 (KATO Corrections and Clarifications) for nvme-tcp. nvme-tcp was choosen as an example to demonstrate the approach taken in the patchset. Other fabric transports, nvme-rdma and nvme-fc, will be added including the feedback received in this RFC.

TP4129 requires nvme controller to not immediately cancel inflight requests when connection is lost between initiator and target. Instead, inflight requests need to be held for a duration that is long enough to allow target to learn about connection loss and quiesce pending commands. Only then pending requests on the initiator side can be canceled and possibly retried safely on another path. The main issue TP4129 tries to address is ABA corruption that could happen if inflight requests are tried immediately on another path.

Requests hold timeout has two components:

- KATO timeout is the time sufficient for target to learn about the connection loss. It depends on whether command based or traffic based keepalive is used. As per TP4129 the timeout is supposed to be 3 x KATO for traffic based keepalive and 2 * KATO for command based keepalive.

- CQT is the time needed by target controller to quiesce in flight nvme commands after the controller learns about connection loss.

On controller reset or delete cancel inflight requests if controller was disabled correctly. Otherwise, hold the requests until it is safe to be released.

Jyoti Rani (1):
nvme-core: Read CQT wait from identify controller response

Mohamed Khalfella (6):
nvmef: Add nvmef_req_hold_timeout_ms() to calculate kato request hold
time
nvme-tcp: Move freeing tagset out of nvme_tcp_teardown_io_queues()
nvme-tcp: Move freeing admin tagset out of
nvme_tcp_teardown_admin_queue()
nvme-tcp: Split nvme_tcp_teardown_io_queues() into two functions
nvme-core: Add support for holding inflight requests
nvme-tcp: Do not immediately cancel inflight requests during recovery

 drivers/nvme/host/core.c    | 62 +++++++++++++++++++++++++++++++++++++
 drivers/nvme/host/fabrics.h |  7 +++++
 drivers/nvme/host/nvme.h    |  5 +++
 drivers/nvme/host/tcp.c     | 56 +++++++++++++++++++++------------
 include/linux/nvme.h        |  4 ++-
 5 files changed, 114 insertions(+), 20 deletions(-)
Signature · 1 line
2.48.1