Skip to content

rust: clean and enable Clippy `doc_markdown` lint

Miguel Ojeda dri-devel linux-devicetree linux-kbuild linux-patches linux-pci lkml rust-for-linux 1 version Applied

Status from this message: Applied to `rust-next`-- thanks everyone!

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest10 patches 13 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/10drm/panic: add missing spacedrivers/gpu/drm/drm_panic_qr.rs+1 -11 reply
2/10drm/panic: add missing Markdown code spandrivers/gpu/drm/drm_panic_qr.rs+1 -13 replies
3/10rust: alloc: add missing Markdown code spansrust/kernel/alloc.rs+2 -20 replies
4/10rust: alloc: add missing Markdown code spanrust/kernel/alloc/allocator_test.rs+1 -10 replies
5/10rust: dma: add missing Markdown code spanrust/kernel/dma.rs+1 -10 replies
6/10rust: of: add missing Markdown code spanrust/kernel/of.rs+1 -10 replies
7/10rust: pci: fix docs related to missing Markdown code spansrust/kernel/pci.rs+9 -62 replies
8/10rust: platform: fix docs related to missing Markdown code spansrust/kernel/platform.rs+5 -40 replies
9/10rust: task: add missing Markdown code spans and intra-doc linksrust/kernel/task.rs+2 -20 replies
10/10rust: kbuild: enable `doc_markdown` Clippy lint.clippy.toml Makefile+5 -00 replies

Reviews trailers per patch

2 of 10 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchBenno LossinJocelyn FalempeGreg Kroah-HartmanDanilo Krummrich
SeriesR-b A-b A-b
1/10R-b
2/10R-b
3/10
4/10
5/10
6/10
7/10
8/10
9/10
10/10

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v1 thread

Cover letter [PATCH 00/10] rust: clean and enable Clippy `doc_markdown` lint

This is how it would look like -- I am not sure how many false positives we will get, so I marked the last commit as RFC and perhaps we just want this lint as an opt-in in e.g. W=2.

However, so far, we only got one ("KUnit"), plus a couple others that are in C side comments that were copied, and thus someone may want to keep them exactly in sync. So it seems pretty OK so far.

Another question is whether we want to commit to something like the global list in .clippy.toml.

Anyway, please take a look -- the other commits should probably be picked even if we do not enable the lint.

Thanks!

Miguel Ojeda (10):
drm/panic: add missing space
drm/panic: add missing Markdown code span
rust: alloc: add missing Markdown code spans
rust: alloc: add missing Markdown code span
rust: dma: add missing Markdown code span
rust: of: add missing Markdown code span
rust: pci: fix docs related to missing Markdown code spans
rust: platform: fix docs related to missing Markdown code spans
rust: task: add missing Markdown code spans and intra-doc links
rust: kbuild: enable doc_markdown Clippy lint

 .clippy.toml                        |  4 ++++
 Makefile                            |  1 +
 drivers/gpu/drm/drm_panic_qr.rs     |  4 ++--
 rust/kernel/alloc.rs                |  4 ++--
 rust/kernel/alloc/allocator_test.rs |  2 +-
 rust/kernel/dma.rs                  |  2 +-
 rust/kernel/of.rs                   |  2 +-
 rust/kernel/pci.rs                  | 15 +++++++++------
 rust/kernel/platform.rs             |  9 +++++----
 rust/kernel/task.rs                 |  4 ++--
 10 files changed, 28 insertions(+), 19 deletions(-)

--
2.49.0