Skip to content

Fix PLL lock timeout and calibration wait time

Devarsh Thakkar linux-phy lkml llvm oe-kbuild-all 3 versions – Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest2 patches 7 repliesApplied
  2. v32 patches 7 repliesSuperseded
  3. v22 patches 6 repliesSuperseded

Changes in v4 from the cover letter

- Optimize wait_for_pll_lock, wait_for_cmn_ready calls to oneline using conditional operator
- Remove superflous init for ret variable in cdns_dphy_configure
- Enable pll and psm ref clocks before configuring PLL
- Update commit message to refer to TRM
- Rebased on top of:
https://lore.kernel.org/all/[email protected]/
https://lore.kernel.org/all/[email protected]/
from the series:
https://lore.kernel.org/all/[email protected]/

Patches in v4 Applied

#Subject and filesSizeRepliesApplied
1/2phy: cadence: cdns-dphy: Fix PLL lock and O_CMN_READY pollingdrivers/phy/cadence/cdns-dphy.c+92 -322 replies
2/2phy: cadence: cdns-dphy: Update calibration wait time for startup state machinedrivers/phy/cadence/cdns-dphy.c+3 -13 replies

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchHarikrishna ShenoyTomi Valkeinen
SeriesR-b
1/2T-b
2/2T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/2] Fix PLL lock timeout and calibration wait time

This fixes PLL lockup and O_CMN_READY timeout by moving the polling function after common state machine gets enabled. Also fix the calibration wait time to optimize the polling time.

NOTE: This needs to be applied on top of
https://lore.kernel.org/all/[email protected]/
https://lore.kernel.org/all/[email protected]/
from the series:
https://lore.kernel.org/all/[email protected]/

Changelog:
V4:
- Optimize wait_for_pll_lock, wait_for_cmn_ready calls to oneline using conditional operator
- Remove superflous init for ret variable in cdns_dphy_configure
- Enable pll and psm ref clocks before configuring PLL
- Update commit message to refer to TRM
- Rebased on top of:
https://lore.kernel.org/all/[email protected]/
https://lore.kernel.org/all/[email protected]/
from the series:
https://lore.kernel.org/all/[email protected]/

V3:
- Use read-modify-write for using calibrated value for PLL
lock time
- Move out PLL clock configuration part to power_on function

V2: Separate patch for calibration logic and
return error code on polling

Previous versions:
V3: https://lore.kernel.org/all/[email protected]/
V2: https://lore.kernel.org/all/[email protected]/
V1: https://lore.kernel.org/all/[email protected]/

Test logs:

Rangediff:
V3->V4:
https://gist.github.com/devarsht/e4db52e1f4aec2d45596b3ed019e92ef

V2->V3:
https://gist.github.com/devarsht/c4d2c4f6715ec7aa4df4cb2c7991b7aa

Devarsh Thakkar (2):
phy: cadence: cdns-dphy: Fix PLL lock and O_CMN_READY polling
phy: cadence: cdns-dphy: Update calibration wait time for startup
state machine

 drivers/phy/cadence/cdns-dphy.c | 126 ++++++++++++++++++++++++--------
 1 file changed, 94 insertions(+), 32 deletions(-)
Signature · 1 line
2.39.1