PCI/arm64/ath11k/ath12k: Rename pwrctrl Kconfig symbols
Status from this message: Applied to pci/pwrctrl for v6.16, thanks!
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest4 patches 5 repliesApplied
- v14 patches 7 repliesSuperseded
Changes in v2 from the cover letter
- drop deprecated symbol for the new slot driver to avoid having to a add a new user visible symbol (e.g. any early adopters will be asked to enable the renamed option again)
- move arm64 patch last two avoid temporarily not having the pwrseq driver selected (Jonas)
Patches in v2 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | PCI/pwrctrl: Rename pwrctrl Kconfig symbols and slot moduledrivers/ drivers/ | +20 | 0 replies | |
| 2/4 | wifi: ath11k: switch to PCI_PWRCTRL_PWRSEQdrivers/ | +1 | 0 replies | |
| 3/4 | wifi: ath12k: switch to PCI_PWRCTRL_PWRSEQdrivers/ | +1 | 0 replies | |
| 4/4 | arm64: Kconfig: switch to HAVE_PWRCTRLarch/ | +1 | 1 reply |
Reviews trailers per patch
All 4 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Manivannan Sadhasivam | Bartosz Golaszewski | Jeff Johnson |
|---|---|---|---|
| Series | A-b | ||
| 1/4 | A-b | A-b | |
| 2/4 | A-b | A-b | A-b |
| 3/4 | A-b | A-b | A-b |
| 4/4 | A-b | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH v2 0/4] PCI/arm64/ath11k/ath12k: Rename pwrctrl Kconfig symbols
The PCI pwrctrl framework was renamed after being merged, but the Kconfig symbols still reflect the old name ("pwrctl" without an "r").
This leads to people not knowing how to refer to the framework in writing, inconsistencies in module naming, etc.
Let's rename also the Kconfig symbols before this gets any worse.
The ath11k, ath12k and arm64 changes could go theoretically go through the corresponding subsystem trees in turn once they have the new symbols, but to avoid tracking dependencies over multiple cycles it is much preferred to have all of these go in through the PCI tree.
The wifi patches have been acked by Jeff and I don't think Will or Catalin will mind the single rename in arm64 if they don't see this message in time.
Note that the patches could be squashed into one, but keeping them separate highlights the changes done to other subsystems. I also find it easier to review the changes this way.
There are some new pwrctrl drivers and an arm64 defconfig change on the lists, but the former should also go in through PCI anyway while we can make sure that the defconfig update matches the new slot symbol.
Note that getting this rename into rc1 would be great as that way it would end up in most subsystem trees soon as well.
Johan
Changes in v2:
- drop deprecated symbol for the new slot driver to avoid having to a add a new user visible symbol (e.g. any early adopters will be asked to enable the renamed option again)
- move arm64 patch last two avoid temporarily not having the pwrseq driver selected (Jonas)
Johan Hovold (4):
PCI/pwrctrl: Rename pwrctrl Kconfig symbols and slot module
wifi: ath11k: switch to PCI_PWRCTRL_PWRSEQ
wifi: ath12k: switch to PCI_PWRCTRL_PWRSEQ
arm64: Kconfig: switch to HAVE_PWRCTRL
arch/arm64/Kconfig.platforms | 2 +- drivers/net/wireless/ath/ath11k/Kconfig | 2 +- drivers/net/wireless/ath/ath12k/Kconfig | 2 +- drivers/pci/pwrctrl/Kconfig | 22 ++++++++++++++++------ drivers/pci/pwrctrl/Makefile | 8 ++++---- 5 files changed, 23 insertions(+), 13 deletions(-)
Signature · 1 line
2.49.0