tracing: Clean up persistent ring buffer code
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v6 Latest4 patches 6 repliesIn review
- v54 patches 13 repliesSuperseded
- v44 patches 2 repliesSuperseded
Earlier versions · 3
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v3 | 5 patches | 2 replies | Superseded | |
| v2 | 2 patches | 32 replies | Superseded | |
| v1 | 2 patches | 0 replies | Superseded |
Patches in v6 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | tracing: Enforce the persistent ring buffer to be page alignedDocumentation/ Documentation/ kernel/ | +14 | 0 replies | |
| 2/4 | tracing: Have reserve_mem use phys_to_virt() and separate from memmap bufferkernel/ kernel/ | +17 | 0 replies | |
| 3/4 | tracing: Use vmap_page_range() to map memmap ring bufferkernel/ | +16 | 3 replies | |
| 4/4 | ring-buffer: Use flush_kernel_vmap_range() over flush_dcache_folio()kernel/ | +3 | 0 replies |
Reviews trailers per patch
None of the 4 patches has a Reviewed-by or Acked-by.
| Patch | Guenter Roeck |
|---|---|
| 1/4 | |
| 2/4 | |
| 3/4 | T-b |
| 4/4 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v6 0/4] tracing: Clean up persistent ring buffer code
Now that I learned that the memory passed back from reserve_mem is part of the memory allocator and just "reserved" and the memory is already virtually mapped, it can simply use phys_to_virt() on the physical memory that is returned to get the virtual mapping for that memory!
(Thanks Mike!)
That makes things much easier, especially since it means that the memory returned by reserve_mem is no different than the memory retrieved by page_alloc(). This allows that memory to be memory mapped to user space no differently than it is mapped by the normal buffer.
This new series does the following:
- Enforce the memory mapping is page aligned (both the address and the size). If not, it errors out.
- Use phys_to_virt() to get to the virtual memory from the reserve_mem returned addresses. As the memory is already freed via reserve_mem_release_by_name() and it's not mapped by vmap() anymore, the free ring buffer code doesn't need to do anything special for this mapping.
- Treat the buffer allocated via memmap differently. It still needs to be virtually mapped (cannot use phys_to_virt) and it must not be freed nor memory mapped to user space. A new flag is added when a buffer is created this way to prevent it from ever being memory mapped to user space and the ref count is upped so that it can never be freed.
- Use vmap_page_range() instead of using kmalloc_array() to create an array of struct pages for vmap().
- Use flush_kernel_vmap_range() instead of flush_dcache_folio()
Changes since v5: https://lore.kernel.org/linux-trace-kernel/[email protected]/
- Use %pa instead of %lx for start and size sizes (Mike Rapoport)
- Updated change log to use memblock_alloc() instead of memblock_reserve() (Mike Rapoport)
Steven Rostedt (4):
tracing: Enforce the persistent ring buffer to be page aligned
tracing: Have reserve_mem use phys_to_virt() and separate from memmap buffer
tracing: Use vmap_page_range() to map memmap ring buffer
ring-buffer: Use flush_kernel_vmap_range() over flush_dcache_folio()
----
Documentation/admin-guide/kernel-parameters.txt | 2 + Documentation/trace/debugging.rst | 2 + kernel/trace/ring_buffer.c | 5 +- kernel/trace/trace.c | 66 ++++++++++++++++--------- kernel/trace/trace.h | 1 + 5 files changed, 50 insertions(+), 26 deletions(-)