Skip to content

coresight: catu: Introduce refcount and spinlock for enabling/disabling

Yabin Cui linux-arm-kernel lkml 5 versions – Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest2 patches 4 repliesApplied
  2. v42 patches 5 repliesSuperseded
  3. v32 patches 4 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v23 patches12 repliesSuperseded
v11 patch3 repliesSuperseded

Changes in v5 from the cover letter

- Collect Review-by tags.
- return -EINVAL for unknown types in coresight_enable_path.

Patches in v5 Applied

#Subject and filesSizeRepliesApplied
1/2coresight: catu: Introduce refcount and spinlock for enabling/disablingdrivers/hwtracing/coresight/coresight-catu.c drivers/hwtracing/coresight/coresight-catu.h+18 -81 reply
2/2coresight: core: Disable helpers for devices that fail to enabledrivers/hwtracing/coresight/coresight-core.c+10 -52 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchJames ClarkLeo YanMike Leach
1/2R-b R-b
2/2R-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v5 thread

Cover letter [PATCH v5 0/2] coresight: catu: Introduce refcount and spinlock for enabling/disabling

Hi Coresight maintainers,

When tracing ETM data on multiple CPUs concurrently via the perf interface, the CATU device is shared across different CPU paths. This can lead to race conditions when multiple CPUs attempt to enable or disable the CATU device simultaneously. This patchset is to fix race conditions when enabling/disabling a CATU device.

Changes since v4:
- Collect Review-by tags.
- return -EINVAL for unknown types in coresight_enable_path.

Changes since v3:
- Add newlines between variable definition and guard().
- Add path parameter when calling coresight_disable_helpers.
- Use "goto err_disable_helpers" in coresight_enable_path().

Changes since v2:
- In catu_disable(), return 0 when refcnt > 0.
- Remove the patch checking enabled mode.
- Disable helpers at the places where a coresight device fails to enable.

Changes since v1:
- Use raw_spinlock_t and guard().
- Add a patch to check enabled mode.
- Add a patch to disable helpers when fails to enable a device.

Yabin Cui (2):
coresight: catu: Introduce refcount and spinlock for
enabling/disabling
coresight: core: Disable helpers for devices that fail to enable

 drivers/hwtracing/coresight/coresight-catu.c | 25 +++++++++++++-------
 drivers/hwtracing/coresight/coresight-catu.h |  1 +
 drivers/hwtracing/coresight/coresight-core.c | 11 ++++++---
 3 files changed, 26 insertions(+), 11 deletions(-)
Signature · 1 line
2.49.0.967.g6a0df3ecc3-goog