Skip to content

ipmi: bmc-sim improvements

Nicholas Piggin qemu-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest5 patches 5 repliesIn review
  2. v25 patches 8 repliesSuperseded
  3. v13 patches 7 repliesSuperseded

Changes in v3 from the cover letter

- Don't log watchog flag should not apply to watchdog expiry field.
- Moved protocol type field from class to IPMIFwInfo.
- Rename new FwInfo member irq to irq_source.
- Add comments about handling PCI devices to existing callers of ->fwinfo

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5ipmi/pci-ipmi-bt: Rename copy-paste variableshw/ipmi/pci_ipmi_bt.c+19 -190 replies
2/5ipmi: add fwinfo to pci ipmi deviceshw/acpi/ipmi.c hw/ipmi/isa_ipmi_bt.c hw/ipmi/isa_ipmi_kcs.c +4 more+38 -21 reply
3/5ipmi/bmc-sim: Add 'Get Channel Info' commandhw/ipmi/ipmi_bmc_sim.c hw/ipmi/ipmi_bt.c hw/ipmi/ipmi_kcs.c +1 more+79 -20 replies
4/5ipmi/bmc-sim: implement watchdog dont log flaghw/ipmi/ipmi_bmc_sim.c+17 -90 replies
5/5ipmi/bmc-sim: add error handling for 'Set BMC Global Enables' commandhw/ipmi/ipmi_bmc_sim.c+9 -10 replies

Reviews trailers per patch

2 of 5 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchPhilippe Mathieu-DaudéCorey Minyard
SeriesA-b
1/5R-b
2/5R-b
3/5
4/5
5/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/5] ipmi: bmc-sim improvements

These little things came up when looking at behaviour of IPMI with the bmc-sim implementation running the ppc powernv machine, and trying to clean up error messages and missing features.

Since v1 (thanks to Corey for review and suggestions):
- Added fwinfo to PCI devices
- Report interrupt number in Get Channel Info for ISA, PCI, and unknown/unassigned.
- Fix error reporting for Get Channel Info unsupported channels. Verify it is the correct error code that ipmitool looks for
https://github.com/ipmitool/ipmitool/blob/master/lib/ipmi_channel.c#L256C16-L256C45
- Change _CH_ to _CHANNEL_ in some defines names.
- Also avoid adding event logs with watchdog don't log flag.

Since v2:
- Don't log watchog flag should not apply to watchdog expiry field.
- Moved protocol type field from class to IPMIFwInfo.
- Rename new FwInfo member irq to irq_source.
- Add comments about handling PCI devices to existing callers of ->fwinfo

Thanks,
Nick

Nicholas Piggin (5):
ipmi/pci-ipmi-bt: Rename copy-paste variables
ipmi: add fwinfo to pci ipmi devices
ipmi/bmc-sim: Add 'Get Channel Info' command
ipmi/bmc-sim: implement watchdog dont log flag ipmi/bmc-sim: add error handling for 'Set BMC Global Enables' command

 include/hw/ipmi/ipmi.h     |  15 ++++++
 hw/acpi/ipmi.c             |   3 +-
 hw/ipmi/ipmi_bmc_sim.c     | 104 ++++++++++++++++++++++++++++++++-----
 hw/ipmi/ipmi_bt.c          |   2 +
 hw/ipmi/ipmi_kcs.c         |   1 +
 hw/ipmi/isa_ipmi_bt.c      |   1 +
 hw/ipmi/isa_ipmi_kcs.c     |   1 +
 hw/ipmi/pci_ipmi_bt.c      |  50 +++++++++++-------
 hw/ipmi/pci_ipmi_kcs.c     |  11 ++++
 hw/smbios/smbios_type_38.c |   7 ++-
 10 files changed, 162 insertions(+), 33 deletions(-)
Signature · 1 line
2.47.1